Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2704763002:
[Mac] Fix crashpad_handler @rpath in the component build. (Closed)
|
Created:
3 years, 10 months ago by Robert Sesek Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Fix crashpad_handler @rpath in the component build.
After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b,
crashpad_handler would fail to start in a component build with this error:
dyld: Library not loaded: @rpath/libbase.dylib
Referenced from:
/Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium
Framework.framework/Helpers/crashpad_handler
Reason: image not found
BUG=693721, 662466
R=mark@chromium.org
Review-Url: https://codereview.chromium.org/2704763002
Cr-Commit-Position: refs/heads/master@{#451441}
Committed: https://chromium.googlesource.com/chromium/src/+/91bfdf3e5fd8b4403f1a346552c0ad991c52913d
Patch Set 1 #
Messages
Total messages: 27 (13 generated)
Description was changed from
==========
[Mac] Fix crashpad_handler @rpath in the component build.
After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b,
crashpad_handler would fail to start in a component build with this error:
dyld: Library not loaded: @rpath/libbase.dylib
Referenced from:
/Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium
Framework.framework/Helpers/crashpad_handler
Reason: image not found
BUG=693721
R=mark@chromium.org
==========
to
==========
[Mac] Fix crashpad_handler @rpath in the component build.
After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b,
crashpad_handler would fail to start in a component build with this error:
dyld: Library not loaded: @rpath/libbase.dylib
Referenced from:
/Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium
Framework.framework/Helpers/crashpad_handler
Reason: image not found
BUG=693721,662466
R=mark@chromium.org
==========
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + thakis@chromium.org
On 2017/02/17 21:55:06, Nico wrote: > Do the other @loader_path refs at > > https://chromium.googlesource.com/chromium/src/+blame/6bab2561839d0c280b5490b... Maybe, but this isn't enabled yet and the versioning was explicitly for this thing, so going to leave it. > https://chromium.googlesource.com/chromium/src/+blame/6bab2561839d0c280b5490b... No, content_shell_framework is (currently) un-versioned. > https://chromium.googlesource.com/chromium/src/+blame/6bab2561839d0c280b5490b... No, the Helper.app isn't part of the framework
cool, lgtm (might even mean something since this is below build/ :-P)
On 2017/02/17 21:57:25, Nico wrote: > cool, lgtm (might even mean something since this is below build/ :-P) Seems to like it! Thanks.
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487391959154710, "parent_rev":
"942dfae2326142b0af47b32c407b70c2e13e86fc", "commit_rev":
"91bfdf3e5fd8b4403f1a346552c0ad991c52913d"}
Message was sent while issue was closed.
Description was changed from
==========
[Mac] Fix crashpad_handler @rpath in the component build.
After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b,
crashpad_handler would fail to start in a component build with this error:
dyld: Library not loaded: @rpath/libbase.dylib
Referenced from:
/Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium
Framework.framework/Helpers/crashpad_handler
Reason: image not found
BUG=693721,662466
R=mark@chromium.org
==========
to
==========
[Mac] Fix crashpad_handler @rpath in the component build.
After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b,
crashpad_handler would fail to start in a component build with this error:
dyld: Library not loaded: @rpath/libbase.dylib
Referenced from:
/Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium
Framework.framework/Helpers/crashpad_handler
Reason: image not found
BUG=693721,662466
R=mark@chromium.org
Review-Url: https://codereview.chromium.org/2704763002
Cr-Commit-Position: refs/heads/master@{#451441}
Committed:
https://chromium.googlesource.com/chromium/src/+/91bfdf3e5fd8b4403f1a346552c0...
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/91bfdf3e5fd8b4403f1a346552c0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
