MD Settings: Fix date and time layout

MD Settings: Fix date and time layout

BUG=624707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2704733002
Cr-Commit-Position: refs/heads/master@{#451825}
Committed: https://chromium.googlesource.com/chromium/src/+/df7c768a829d848bc7ff934d6ed3b20bdb9529d9

[stevenjb, 2017-02-17 19:45:29]

Description was changed from

==========
MD Settings: Fix date and time layout

BUG=624707
==========

to

==========
MD Settings: Fix date and time layout

BUG=624707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-17 19:49:57]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2017-02-17 19:49:58]

Screenshot in issue

[michaelpg, 2017-02-17 22:22:12]

lgtm, thanks!

https://codereview.chromium.org/2704733002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/date_time_page/date_time_page.html
(right):

https://codereview.chromium.org/2704733002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/date_time_page/date_time_page.html:19:
var(--settings-box-row-padding) + var(--settings-indent-width));
we have this calc in a few other places, is it worth sharing it, or trying to
use something like .list-frame here?

https://cs.chromium.org/search/?q=settings-box-row-padding%5C)%5Cs%5C%2B%5Csv...

[stevenjb, 2017-02-18 19:54:06]

PTAL at shared var changes

https://codereview.chromium.org/2704733002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/date_time_page/date_time_page.html
(right):

https://codereview.chromium.org/2704733002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/date_time_page/date_time_page.html:19:
var(--settings-box-row-padding) + var(--settings-indent-width));
On 2017/02/17 22:22:12, michaelpg wrote:
> we have this calc in a few other places, is it worth sharing it, or trying to
> use something like .list-frame here?
> 
>
https://cs.chromium.org/search/?q=settings-box-row-padding%5C)%5Cs%5C%2B%5Csv...

list-frame messes with the top/bottom padding, but it makes sense to use a
single var for these (I'd meant to look for other uses but forgot, so thanks).
Done.

[michaelpg, 2017-02-19 05:40:45]

lgtm

https://codereview.chromium.org/2704733002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2704733002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:19:
var(--settings-box-row-padding) + var(--settings-indent-width));
indent +2

[stevenjb, 2017-02-21 17:50:14]

https://codereview.chromium.org/2704733002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2704733002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:19:
var(--settings-box-row-padding) + var(--settings-indent-width));
On 2017/02/19 05:40:45, michaelpg wrote:
> indent +2

Done.

[stevenjb, 2017-02-21 17:50:19]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-02-21 17:50:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2704733002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-21 17:51:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 20:05:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487699419456170,
"parent_rev": "1eaad787aed9c3add0cfe3e1fcdb65cf98f5c6c0", "commit_rev":
"df7c768a829d848bc7ff934d6ed3b20bdb9529d9"}

[commit-bot: I haz the power, 2017-02-21 20:07:59]

Description was changed from

==========
MD Settings: Fix date and time layout

BUG=624707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix date and time layout

BUG=624707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2704733002
Cr-Commit-Position: refs/heads/master@{#451825}
Committed:
https://chromium.googlesource.com/chromium/src/+/df7c768a829d848bc7ff934d6ed3...
==========

[commit-bot: I haz the power, 2017-02-21 20:08:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/df7c768a829d848bc7ff934d6ed3...