Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2704713002: MD Settings: Should not show "Import and Bind" button on non-CrOS. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, Dan Beam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Should not show "Import and Bind" button on non-CrOS. BUG=600468 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2704713002 Cr-Commit-Position: refs/heads/master@{#451407} Committed: https://chromium.googlesource.com/chromium/src/+/6bdd26b43756cb3fb97568d7f126359aff6a5904

Patch Set 1 #

Patch Set 2 : Need more preproccessing. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (6 generated)
dpapad
3 years, 10 months ago (2017-02-17 19:39:38 UTC) #2
stevenjb
doh. lgtm.
3 years, 10 months ago (2017-02-17 20:06:58 UTC) #5
dpapad
https://codereview.chromium.org/2704713002/diff/20001/chrome/browser/resources/settings/settings_resources.grd File chrome/browser/resources/settings/settings_resources.grd (right): https://codereview.chromium.org/2704713002/diff/20001/chrome/browser/resources/settings/settings_resources.grd#newcode281 chrome/browser/resources/settings/settings_resources.grd:281: preprocess="true" Actually this file also needs to be preprocessed.
3 years, 10 months ago (2017-02-17 20:22:37 UTC) #6
stevenjb
Would be nice if this were automated somehow... still lgtm.
3 years, 10 months ago (2017-02-17 20:34:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704713002/20001
3 years, 10 months ago (2017-02-17 20:40:34 UTC) #9
dpapad
On 2017/02/17 at 20:34:26, stevenjb wrote: > Would be nice if this were automated somehow... ...
3 years, 10 months ago (2017-02-17 20:41:21 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 00:31:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6bdd26b43756cb3fb97568d7f126...

Powered by Google App Engine
This is Rietveld 408576698