Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2704663004: Remove CRWSessionEntry from NavigationManagerImpl. (Closed)

Created:
3 years, 10 months ago by kkhorimoto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CRWSessionEntry from NavigationManagerImpl. BUG=454984 Review-Url: https://codereview.chromium.org/2704663004 Cr-Commit-Position: refs/heads/master@{#452413} Committed: https://chromium.googlesource.com/chromium/src/+/2cae20f73af243e449f333646837cb7a98cdbf84

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added size_t todos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
M ios/web/navigation/navigation_manager_impl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 8 chunks +17 lines, -30 lines 0 comments Download
M ios/web/public/navigation_manager.h View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kkhorimoto
3 years, 10 months ago (2017-02-17 23:41:00 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2704663004/diff/1/ios/web/navigation/navigation_manager_impl.mm File ios/web/navigation/navigation_manager_impl.mm (right): https://codereview.chromium.org/2704663004/diff/1/ios/web/navigation/navigation_manager_impl.mm#newcode269 ios/web/navigation/navigation_manager_impl.mm:269: if (idx >= GetItems().size()) Do you want to ...
3 years, 10 months ago (2017-02-18 01:21:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704663004/20001
3 years, 10 months ago (2017-02-23 05:22:14 UTC) #6
kkhorimoto
https://codereview.chromium.org/2704663004/diff/1/ios/web/navigation/navigation_manager_impl.mm File ios/web/navigation/navigation_manager_impl.mm (right): https://codereview.chromium.org/2704663004/diff/1/ios/web/navigation/navigation_manager_impl.mm#newcode269 ios/web/navigation/navigation_manager_impl.mm:269: if (idx >= GetItems().size()) On 2017/02/18 01:21:38, Eugene But ...
3 years, 10 months ago (2017-02-23 05:22:31 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 05:55:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2cae20f73af243e449f333646837...

Powered by Google App Engine
This is Rietveld 408576698