Compositing: avoid flakes in overflow-positioning.html

Compositing: avoid flakes in overflow-positioning.html

To force a style recalc before triggering the transition, we explicitly
use getComputedStyle instead of hoping setTimeout(0) will suffice.

We pause the transition instead of hoping a 1000s transitions makes
little progress during a setTimeout(0).


BUG=692733
Review-Url: https://codereview.chromium.org/2704583003
Cr-Commit-Position: refs/heads/master@{#451552}
Committed: https://chromium.googlesource.com/chromium/src/+/6773ab42490210d02468d50e4298c7587209d6aa

[Eric Willigers, 2017-02-17 03:45:14]

ericwilligers@chromium.org changed reviewers:
+ wkorman@chromium.org

[Eric Willigers, 2017-02-17 03:45:23]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 03:46:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 05:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 05:55:47]

Dry run: This issue passed the CQ dry run.

[wkorman, 2017-02-17 23:12:39]

lgtm

https://codereview.chromium.org/2704583003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/compositing/overflow/overflow-positioning.html
(right):

https://codereview.chromium.org/2704583003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/compositing/overflow/overflow-positioning.html:66:
internals.pauseAnimations(0);
This is usually behind an if (window.internals), see for example
animations/interpolation/left-zoomed-interpolation.html.

Just so that when running locally in content shell or browser one doesn't see JS
error.

[Eric Willigers, 2017-02-20 02:28:52]

https://codereview.chromium.org/2704583003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/compositing/overflow/overflow-positioning.html
(right):

https://codereview.chromium.org/2704583003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/compositing/overflow/overflow-positioning.html:66:
internals.pauseAnimations(0);
On 2017/02/17 23:12:38, wkorman wrote:
> This is usually behind an if (window.internals), see for example
> animations/interpolation/left-zoomed-interpolation.html.
> 
> Just so that when running locally in content shell or browser one doesn't see
JS
> error.

Done.

[Eric Willigers, 2017-02-20 02:28:57]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-02-20 02:28:57]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2704583003/#ps20001
(title: "Test if internals available")

[commit-bot: I haz the power, 2017-02-20 02:29:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 03:25:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487557737377770,
"parent_rev": "e39228668f52dd5eaf14f5f0fff998b858b5547d", "commit_rev":
"6773ab42490210d02468d50e4298c7587209d6aa"}

[commit-bot: I haz the power, 2017-02-20 03:26:07]

Description was changed from

==========
Compositing: avoid flakes in overflow-positioning.html

To force a style recalc before triggering the transition, we explicitly
use getComputedStyle instead of hoping setTimeout(0) will suffice.

We pause the transition instead of hoping a 1000s transitions makes
little progress during a setTimeout(0).


BUG=692733
==========

to

==========
Compositing: avoid flakes in overflow-positioning.html

To force a style recalc before triggering the transition, we explicitly
use getComputedStyle instead of hoping setTimeout(0) will suffice.

We pause the transition instead of hoping a 1000s transitions makes
little progress during a setTimeout(0).


BUG=692733

Review-Url: https://codereview.chromium.org/2704583003
Cr-Commit-Position: refs/heads/master@{#451552}
Committed:
https://chromium.googlesource.com/chromium/src/+/6773ab42490210d02468d50e4298...
==========

[commit-bot: I haz the power, 2017-02-20 03:26:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6773ab42490210d02468d50e4298...