Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2704553002:
chromeos: Makes InputMethodMus dispatch immediately if no server (Closed)
Descriptionchromeos: Makes InputMethodMus dispatch immediately if no server
This may come up in tests that dispatch events.
BUG=693114
TEST=covered by tests
R=moshayedi@chromium.org, sadrul@chromium.org
TBR=sadrul@chromium.org
Review-Url: https://codereview.chromium.org/2704553002
Cr-Commit-Position: refs/heads/master@{#451154}
Committed: https://chromium.googlesource.com/chromium/src/+/b39a71e6e5f10e51c57c0aa671f7fbfcc3abacd2
Patch Set 1 #Patch Set 2 : comment #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by sky@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM.
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== chromeos: Makes InputMethodMus dispatch immediately if no server This may come up in tests that dispatch events. BUG=693114 TEST=covered by tests R=moshayedi@chromium.org ========== to ========== chromeos: Makes InputMethodMus dispatch immediately if no server This may come up in tests that dispatch events. BUG=693114 TEST=covered by tests R=moshayedi@chromium.org, sadrul@chromium.org ==========
sky@chromium.org changed reviewers: + sadrul@chromium.org
Description was changed from ========== chromeos: Makes InputMethodMus dispatch immediately if no server This may come up in tests that dispatch events. BUG=693114 TEST=covered by tests R=moshayedi@chromium.org, sadrul@chromium.org ========== to ========== chromeos: Makes InputMethodMus dispatch immediately if no server This may come up in tests that dispatch events. BUG=693114 TEST=covered by tests R=moshayedi@chromium.org, sadrul@chromium.org TBR=sadrul@chromium.org ==========
TBR Sadrul as Hadi isn't a committer yet.
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487283494473660,
"parent_rev": "cbab2928a12119e08c278656de62a310d97a111d", "commit_rev":
"b39a71e6e5f10e51c57c0aa671f7fbfcc3abacd2"}
Message was sent while issue was closed.
Description was changed from ========== chromeos: Makes InputMethodMus dispatch immediately if no server This may come up in tests that dispatch events. BUG=693114 TEST=covered by tests R=moshayedi@chromium.org, sadrul@chromium.org TBR=sadrul@chromium.org ========== to ========== chromeos: Makes InputMethodMus dispatch immediately if no server This may come up in tests that dispatch events. BUG=693114 TEST=covered by tests R=moshayedi@chromium.org, sadrul@chromium.org TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2704553002 Cr-Commit-Position: refs/heads/master@{#451154} Committed: https://chromium.googlesource.com/chromium/src/+/b39a71e6e5f10e51c57c0aa671f7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b39a71e6e5f10e51c57c0aa671f7... |
