[Autofill] Add Chrome flag that annotates web forms with form and field signatures

[Autofill] Add Chrome flag that annotates web forms with form and field signatures

The signatures are set as HTML attributes. This flag would be useful for debugging and collecting train data.

Review-Url: https://codereview.chromium.org/2704503002
Cr-Commit-Position: refs/heads/master@{#451719}
Committed: https://chromium.googlesource.com/chromium/src/+/c8ff75bcb4213239787068128437f9829a2f0de8

[kolos1, 2017-02-16 15:15:52]

Patchset #1 (id:1) has been deleted

[kolos1, 2017-02-16 15:16:10]

Description was changed from

==========
[Autofill] Add Chrome flag that annotate web forms with form and field
signatures

The signatures are set as HTML attributes. This flag would be useful for
debugging and colleting train data.
==========

to

==========
[Autofill] Add Chrome flag that annotate web forms with form and field
signatures

The signatures are set as HTML attributes. This flag would be useful for
debugging and collecting train data.
==========

[kolos1, 2017-02-16 15:23:47]

Patchset #2 (id:10008) has been deleted

[kolos1, 2017-02-16 15:26:43]

kolos@chromium.org changed reviewers:
+ sebsg@chromium.org

[kolos1, 2017-02-16 15:26:43]

Hi Sebastien,

Please review this CL. This flag is very similar to
#show-autofill-type-predictions, but a bit different. New flag will annotate
form regardless of whether there is server prediction or not. It will also
annotate signin forms with only two fields.

Regards,
Maxim

[kolos1, 2017-02-16 15:27:09]

Description was changed from

==========
[Autofill] Add Chrome flag that annotate web forms with form and field
signatures

The signatures are set as HTML attributes. This flag would be useful for
debugging and collecting train data.
==========

to

==========
[Autofill] Add Chrome flag that annotates web forms with form and field
signatures

The signatures are set as HTML attributes. This flag would be useful for
debugging and collecting train data.
==========

[sebsg, 2017-02-17 16:19:57]

LGTM with a small comment :)

https://codereview.chromium.org/2704503002/diff/20001/components/autofill/con...
File components/autofill/content/renderer/password_autofill_agent.cc (right):

https://codereview.chromium.org/2704503002/diff/20001/components/autofill/con...
components/autofill/content/renderer/password_autofill_agent.cc:571: void
AnnotateFormsWithSignatures(
Can you just add a small comment here to explain the general idea and what it
annotates? :)

[kolos1, 2017-02-20 10:04:54]

Thanks for review Sebastien!

Regards,
Maxim

https://codereview.chromium.org/2704503002/diff/20001/components/autofill/con...
File components/autofill/content/renderer/password_autofill_agent.cc (right):

https://codereview.chromium.org/2704503002/diff/20001/components/autofill/con...
components/autofill/content/renderer/password_autofill_agent.cc:571: void
AnnotateFormsWithSignatures(
On 2017/02/17 16:19:57, sebsg wrote:
> Can you just add a small comment here to explain the general idea and what it
> annotates? :)

Done.

[kolos1, 2017-02-20 10:05:52]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 10:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 11:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 11:29:22]

Dry run: This issue passed the CQ dry run.

[kolos1, 2017-02-21 09:50:04]

The CQ bit was checked by kolos@chromium.org

[kolos1, 2017-02-21 09:50:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2704503002/#ps50001
(title: " ")

[commit-bot: I haz the power, 2017-02-21 09:50:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 09:55:49]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1487670604967570,
"parent_rev": "f384edd5ac54a0f81cd1f4be3bb271d6502c85cf", "commit_rev":
"c8ff75bcb4213239787068128437f9829a2f0de8"}

[commit-bot: I haz the power, 2017-02-21 09:56:26]

Description was changed from

==========
[Autofill] Add Chrome flag that annotates web forms with form and field
signatures

The signatures are set as HTML attributes. This flag would be useful for
debugging and collecting train data.
==========

to

==========
[Autofill] Add Chrome flag that annotates web forms with form and field
signatures

The signatures are set as HTML attributes. This flag would be useful for
debugging and collecting train data.

Review-Url: https://codereview.chromium.org/2704503002
Cr-Commit-Position: refs/heads/master@{#451719}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8ff75bcb4213239787068128437...
==========

[commit-bot: I haz the power, 2017-02-21 09:56:27]

Committed patchset #2 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/c8ff75bcb4213239787068128437...