Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2704423002: Add Youtube auto play integration test (Closed)

Created:
3 years, 10 months ago by Robert Ogden
Modified:
3 years, 10 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, posciak+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Youtube auto play integration test BUG=680584 Review-Url: https://codereview.chromium.org/2704423002 Cr-Commit-Position: refs/heads/master@{#452108} Committed: https://chromium.googlesource.com/chromium/src/+/79daaa960f6d76d857f71233553db0ee8a30f9e1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make test non-Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/chrome_proxy/webdriver/video.py View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Robert Ogden
3 years, 10 months ago (2017-02-21 18:33:32 UTC) #2
RyanSturm
https://codereview.chromium.org/2704423002/diff/1/tools/chrome_proxy/webdriver/video.py File tools/chrome_proxy/webdriver/video.py (right): https://codereview.chromium.org/2704423002/diff/1/tools/chrome_proxy/webdriver/video.py#newcode121 tools/chrome_proxy/webdriver/video.py:121: def testYoutube(self): Desktop only?
3 years, 10 months ago (2017-02-21 18:37:49 UTC) #3
Robert Ogden
On 2017/02/21 18:37:49, Ryan Sturm wrote: > https://codereview.chromium.org/2704423002/diff/1/tools/chrome_proxy/webdriver/video.py > File tools/chrome_proxy/webdriver/video.py (right): > > https://codereview.chromium.org/2704423002/diff/1/tools/chrome_proxy/webdriver/video.py#newcode121 ...
3 years, 10 months ago (2017-02-21 18:40:10 UTC) #4
Robert Ogden
Made the test non-Android. PTAL
3 years, 10 months ago (2017-02-22 16:15:57 UTC) #5
RyanSturm
lgtm Lgtm, did you check if this works on all non-android platforms? I
3 years, 10 months ago (2017-02-22 16:20:51 UTC) #6
Robert Ogden
On 2017/02/22 16:20:51, Ryan Sturm wrote: > lgtm > > Lgtm, did you check if ...
3 years, 10 months ago (2017-02-22 17:13:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704423002/20001
3 years, 10 months ago (2017-02-22 17:14:26 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 17:25:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/79daaa960f6d76d857f71233553d...

Powered by Google App Engine
This is Rietveld 408576698