Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2704383003: Error pages: Break retain cycle NativeContent/StaticHTMLViewController (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Error pages: Break retain cycle NativeContent/StaticHTMLViewController StaticHTMLViewController retains the generator. The generator is implementated by ErrorPageContent, which retain the StaticHTMLViewController. This leads to a leak and the WKWebView is never released. BUG=693178 Review-Url: https://codereview.chromium.org/2695593011 Cr-Commit-Position: refs/heads/master@{#451609} (cherry picked from commit fc155c2704ad95817d98efb4c3dbec239c4c17cb) Review-Url: https://codereview.chromium.org/2704383003 . Cr-Commit-Position: refs/branch-heads/2987@{#635} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b8d01bfd581d8285158819ab99ebbbf59afa6704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -216 lines) Patch
M ios/chrome/browser/ui/static_content/static_html_view_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/web/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/error_page_content.h View 1 chunk +1 line, -6 lines 0 comments Download
M ios/chrome/browser/web/error_page_content.mm View 2 chunks +7 lines, -48 lines 0 comments Download
D ios/chrome/browser/web/error_page_content_unittest.mm View 1 chunk +0 lines, -116 lines 0 comments Download
A ios/chrome/browser/web/error_page_generator.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/error_page_generator.mm View 1 chunk +74 lines, -0 lines 0 comments Download
A + ios/chrome/browser/web/error_page_generator_unittest.mm View 3 chunks +25 lines, -44 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 10 months ago (2017-02-22 08:37:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8d01bfd581d8285158819ab99ebbbf59afa6704.

Powered by Google App Engine
This is Rietveld 408576698