Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Issue 2704313002: Remove gcdPrivate API code. (Closed)

Created:
3 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-closure_chromium.org, asvitkine+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gcdPrivate API code. BUG=691737 Review-Url: https://codereview.chromium.org/2704313002 Cr-Commit-Position: refs/heads/master@{#452379} Committed: https://chromium.googlesource.com/chromium/src/+/63cedc505c14394c2cb47d1ec6fd3ca4b6f27bcc

Patch Set 1 #

Patch Set 2 : Remove gcdPrivate API code. #

Patch Set 3 : Remove gcdPrivate API code. #

Patch Set 4 : Remove gcdPrivate API code. #

Patch Set 5 : Remove gcdPrivate API code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2365 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/gcd_private_api.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 1 chunk +0 lines, -447 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 3 4 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/privet_v3_context_getter.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/privet_v3_context_getter.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/privet_v3_context_getter_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/privet_v3_session.h View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/privet_v3_session.cc View 1 chunk +0 lines, -526 lines 0 comments Download
D chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc View 1 chunk +0 lines, -341 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_constants.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_constants.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_http_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/privet_url_fetcher.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/common/extensions/api/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/common/extensions/api/gcd_private.idl View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 2 chunks +1 line, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcd_private/api/device_info.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcd_private/api/device_info.js View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcd_private/api/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcd_private/api/session.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcd_private/api/session.js View 1 chunk +0 lines, -36 lines 0 comments Download
M extensions/browser/extension_event_histogram_value.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 4 chunks +15 lines, -15 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 6 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Vitaly Buka corp
3 years, 10 months ago (2017-02-21 07:06:51 UTC) #4
Devlin
lgtm
3 years, 10 months ago (2017-02-21 14:08:39 UTC) #11
Alexei Svitkine (slow)
histograms lgtm
3 years, 10 months ago (2017-02-21 16:07:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704313002/80001
3 years, 10 months ago (2017-02-23 01:43:42 UTC) #15
Lei Zhang
Further cleanup in a follow up CL: https://codereview.chromium.org/2714643003/
3 years, 10 months ago (2017-02-23 03:34:43 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 03:44:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/63cedc505c14394c2cb47d1ec6fd...

Powered by Google App Engine
This is Rietveld 408576698