Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2704303002: Simplify conditionals for blink::Location::isActive(). (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify conditionals for blink::Location::isActive(). On navigation or detach, DOMWindow's back pointer to Frame is cleared, so it's only necessary to check that the back pointer to Frame is non-null. BUG=694111 Review-Url: https://codereview.chromium.org/2704303002 Cr-Commit-Position: refs/heads/master@{#451732} Committed: https://chromium.googlesource.com/chromium/src/+/86ff27ab575772808e4aa02430c571f770d556be

Patch Set 1 #

Patch Set 2 : Delete redundant check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/Location.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Location.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
dcheng
3 years, 10 months ago (2017-02-21 08:59:55 UTC) #8
haraken
LGTM
3 years, 10 months ago (2017-02-21 09:49:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704303002/20001
3 years, 10 months ago (2017-02-21 10:17:24 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 11:26:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/86ff27ab575772808e4aa02430c5...

Powered by Google App Engine
This is Rietveld 408576698