Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2704283002: Speculatively deflake BrowsingHistoryHandler::MergeDuplicateResults on Android. (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 10 months ago
Reviewers:
sdefresne, Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, dbeam+watch-history_chromium.org, browser-components-watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculatively deflake BrowsingHistoryHandler::MergeDuplicateResults on Android. This CL removes global time variables in browsing history tests, one of which is unused. These variables were tripping a NOTREACHED() in the implementation of base::Time::LocalMidnight() on Android, where the time was being computed as null. This speculatively deflakes the test on Android. BUG=611747 TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2704283002 Cr-Commit-Position: refs/heads/master@{#451919} Committed: https://chromium.googlesource.com/chromium/src/+/899bc281768913fa13729754b9725d1feadd3c9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -57 lines) Patch
M chrome/browser/history/browsing_history_service_unittest.cc View 3 chunks +50 lines, -53 lines 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dominickn
sdefresne: PTAL at history dbeam: PTAL at webui Thanks!
3 years, 10 months ago (2017-02-21 03:48:24 UTC) #5
sdefresne
lgtm
3 years, 10 months ago (2017-02-21 09:51:01 UTC) #8
dominickn
Since this is just removing an unused variable in a webui test, TBR-ing dbeam.
3 years, 10 months ago (2017-02-22 06:52:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704283002/1
3 years, 10 months ago (2017-02-22 06:53:42 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 08:09:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/899bc281768913fa13729754b972...

Powered by Google App Engine
This is Rietveld 408576698