Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2704273002: Get rid of redundant test first-letter-rtc-crash.html (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of redundant test layout test first-letter-rtc-crash.html This patch gets or redundant layout test "first-letter-rtc-crash.html" for improving code health and reduce maintenance cost. The test verifies the specific edge case of |TextIterator| class. However, the patch [1] changed first-letter handling in |TextIterator| and there are no path verified by path. The test is little minimized ClusterFuzz generated test script, it is hard to read and change. Since the crash is caused by "FindString" command, the expectation is not useful other than having it to indicate not crash. BUG=694307, 694320 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2704273002 Cr-Commit-Position: refs/heads/master@{#451688} Committed: https://chromium.googlesource.com/chromium/src/+/1efb7901eafb3fa00849b5f380ef8409c663b1d2

Patch Set 1 : 2017-02-21T10:20:57 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -90 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash.html View 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yosin_UTC9
PTAL To remove developer pain.
3 years, 10 months ago (2017-02-21 01:30:54 UTC) #5
tkent
lgtm
3 years, 10 months ago (2017-02-21 01:40:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704273002/1
3 years, 10 months ago (2017-02-21 01:46:51 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 02:28:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1efb7901eafb3fa00849b5f380ef...

Powered by Google App Engine
This is Rietveld 408576698