Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2704193002: [ObjC ARC] Converts ios/chrome/app/spotlight:spotlight to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app/spotlight:spotlight to ARC. Automatically generated ARCMigrate commit Notable issues: * in topsites_spotlight_manager.mm, added a strongself to avoid dereferncing a weak pointer (which would cause crashes, but is not a compiler-diagnosed error without ARC). BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2704193002 Cr-Commit-Position: refs/heads/master@{#451650} Committed: https://chromium.googlesource.com/chromium/src/+/dd475891a5721fb6a45b2a7ff92f7f4b22858625

Patch Set 1 #

Patch Set 2 : s/unsafe/weak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -77 lines) Patch
M ios/chrome/app/spotlight/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/spotlight/actions_spotlight_manager.mm View 5 chunks +12 lines, -11 lines 0 comments Download
M ios/chrome/app/spotlight/base_spotlight_manager.mm View 9 chunks +20 lines, -19 lines 0 comments Download
M ios/chrome/app/spotlight/bookmarks_spotlight_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm View 1 10 chunks +18 lines, -20 lines 0 comments Download
M ios/chrome/app/spotlight/spotlight_manager.mm View 4 chunks +13 lines, -15 lines 0 comments Download
M ios/chrome/app/spotlight/spotlight_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/spotlight/topsites_spotlight_manager.mm View 1 9 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
stkhapugin
ptal
3 years, 10 months ago (2017-02-20 15:56:02 UTC) #5
Olivier
lgtm
3 years, 10 months ago (2017-02-20 16:48:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704193002/20001
3 years, 10 months ago (2017-02-20 16:49:26 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 18:04:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd475891a5721fb6a45b2a7ff92f...

Powered by Google App Engine
This is Rietveld 408576698