Update the layout mode first when exiting tablet mode

Update the layout mode first when exiting tablet mode so that
exo's wayland server can update the display and desktop mode atomically.

BUG=692908
TEST=Manual

Review-Url: https://codereview.chromium.org/2704173002
Cr-Commit-Position: refs/heads/master@{#451875}
Committed: https://chromium.googlesource.com/chromium/src/+/8144c4a6052a4709e78b52c777d5e79f5616a26a

[oshima, 2017-02-20 09:28:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 09:28:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 09:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 09:59:13]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-02-21 08:37:36]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 08:37:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-02-21 08:40:06]

Description was changed from

==========
Exit tablet mode and update the screen atomically

BUG=
TEST=
==========

to

==========
Update the layout mode first when exiting tablet mode so that
exo's wayland server can update the display and desktop mode atomically.

BUG=692908
TEST=Manual
==========

[oshima, 2017-02-21 08:40:06]

oshima@chromium.org changed reviewers:
+ reveman@chromium.org, skuhne@chromium.org

[oshima, 2017-02-21 08:40:30]

skuhne@ -> ash
reveman@ -> exo

[commit-bot: I haz the power, 2017-02-21 08:52:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 08:52:51]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[oshima, 2017-02-21 13:24:14]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 13:24:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 14:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 14:12:01]

Dry run: This issue passed the CQ dry run.

[Mr4D (OOO till 08-26), 2017-02-21 16:17:18]

ash - lgtm (even though I do not think that I am an owner for ash/common, ..)

https://codereview.chromium.org/2704173002/diff/40001/ash/common/shell_observ...
File ash/common/shell_observer.h (right):

https://codereview.chromium.org/2704173002/diff/40001/ash/common/shell_observ...
ash/common/shell_observer.h:64: virtual void OnMaximizeModeEnding() {}
Sooner or later we should rename the "..MaximizeMode.." into something like
"..TabletMode.." since that is what it is. But that is something for another
refactor patch.

[reveman, 2017-02-21 16:55:53]

components/exo lgtm

[oshima, 2017-02-21 23:02:31]

On 2017/02/21 16:17:18, Mr4D wrote:
> ash - lgtm (even though I do not think that I am an owner for ash/common, ..)
> 
>
https://codereview.chromium.org/2704173002/diff/40001/ash/common/shell_observ...
> File ash/common/shell_observer.h (right):
> 
>
https://codereview.chromium.org/2704173002/diff/40001/ash/common/shell_observ...
> ash/common/shell_observer.h:64: virtual void OnMaximizeModeEnding() {}
> Sooner or later we should rename the "..MaximizeMode.." into something like
> "..TabletMode.." since that is what it is. But that is something for another
> refactor patch.

Agreed. Let's do it when arc++ development gets stabilized (that is, to become
normal dev cycle :-p).

[oshima, 2017-02-21 23:02:36]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:04:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:31:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487718156154110,
"parent_rev": "22a030be0c75c7a39b938d51d04bcc259bf9fe17", "commit_rev":
"8144c4a6052a4709e78b52c777d5e79f5616a26a"}

[commit-bot: I haz the power, 2017-02-22 01:35:54]

Description was changed from

==========
Update the layout mode first when exiting tablet mode so that
exo's wayland server can update the display and desktop mode atomically.

BUG=692908
TEST=Manual
==========

to

==========
Update the layout mode first when exiting tablet mode so that
exo's wayland server can update the display and desktop mode atomically.

BUG=692908
TEST=Manual

Review-Url: https://codereview.chromium.org/2704173002
Cr-Commit-Position: refs/heads/master@{#451875}
Committed:
https://chromium.googlesource.com/chromium/src/+/8144c4a6052a4709e78b52c777d5...
==========

[commit-bot: I haz the power, 2017-02-22 01:35:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8144c4a6052a4709e78b52c777d5...