Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: components/prefs/in_memory_pref_store.cc

Issue 2704133006: Revert of Add PrefStore::GetValues (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/prefs/in_memory_pref_store.h ('k') | components/prefs/json_pref_store.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/prefs/in_memory_pref_store.h" 5 #include "components/prefs/in_memory_pref_store.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/values.h" 10 #include "base/values.h"
11 11
12 InMemoryPrefStore::InMemoryPrefStore() {} 12 InMemoryPrefStore::InMemoryPrefStore() {}
13 13
14 InMemoryPrefStore::~InMemoryPrefStore() {} 14 InMemoryPrefStore::~InMemoryPrefStore() {}
15 15
16 bool InMemoryPrefStore::GetValue(const std::string& key, 16 bool InMemoryPrefStore::GetValue(const std::string& key,
17 const base::Value** value) const { 17 const base::Value** value) const {
18 return prefs_.GetValue(key, value); 18 return prefs_.GetValue(key, value);
19 } 19 }
20 20
21 std::unique_ptr<base::DictionaryValue> InMemoryPrefStore::GetValues() const {
22 return prefs_.AsDictionaryValue();
23 }
24
25 bool InMemoryPrefStore::GetMutableValue(const std::string& key, 21 bool InMemoryPrefStore::GetMutableValue(const std::string& key,
26 base::Value** value) { 22 base::Value** value) {
27 return prefs_.GetValue(key, value); 23 return prefs_.GetValue(key, value);
28 } 24 }
29 25
30 void InMemoryPrefStore::AddObserver(PrefStore::Observer* observer) { 26 void InMemoryPrefStore::AddObserver(PrefStore::Observer* observer) {
31 observers_.AddObserver(observer); 27 observers_.AddObserver(observer);
32 } 28 }
33 29
34 void InMemoryPrefStore::RemoveObserver(PrefStore::Observer* observer) { 30 void InMemoryPrefStore::RemoveObserver(PrefStore::Observer* observer) {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 68
73 PersistentPrefStore::PrefReadError InMemoryPrefStore::ReadPrefs() { 69 PersistentPrefStore::PrefReadError InMemoryPrefStore::ReadPrefs() {
74 return PersistentPrefStore::PREF_READ_ERROR_NONE; 70 return PersistentPrefStore::PREF_READ_ERROR_NONE;
75 } 71 }
76 72
77 void InMemoryPrefStore::ReportValueChanged(const std::string& key, 73 void InMemoryPrefStore::ReportValueChanged(const std::string& key,
78 uint32_t flags) { 74 uint32_t flags) {
79 for (Observer& observer : observers_) 75 for (Observer& observer : observers_)
80 observer.OnPrefValueChanged(key); 76 observer.OnPrefValueChanged(key);
81 } 77 }
OLDNEW
« no previous file with comments | « components/prefs/in_memory_pref_store.h ('k') | components/prefs/json_pref_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698