Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2704133004: Perf bots for https://codereview.chromium.org/2473743003 (Closed)

Created:
3 years, 10 months ago by nainar
Modified:
3 years, 10 months ago
Reviewers:
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perf bots for https://codereview.chromium.org/2473743003 patch from issue 2611613004 at patchset 1 (http://crrev.com/2611613004#ps1)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -44 lines) Patch
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp View 3 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 3 chunks +28 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 6 chunks +52 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 4 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +13 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/stylerecalc.md View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nainar
Ran the following command: tools/perf/run_benchmark try all-android memory.top_10_mobile The perf console has changed but on ...
3 years, 10 months ago (2017-02-21 02:59:01 UTC) #1
nainar
3 years, 10 months ago (2017-02-21 04:57:23 UTC) #2
On 2017/02/21 at 02:59:01, nainar wrote:
> Ran the following command:
> tools/perf/run_benchmark try all-android memory.top_10_mobile 
> 
> The perf console has changed but on the face of things this patch even though
reading from the HashMap a lot more often doesn't seem to have affected memory. 
> 
> Running perf tests next.

Ran perf tests as well as can be seen above and there has been some improvement
due to the patch. (<1% in update_style and <2% in update_style_cold) So I don't
see any perf problems with landing this patch even with a few changes.

Powered by Google App Engine
This is Rietveld 408576698