Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: gm/rebaseline_server/static/constants.js

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/static/constants.js
diff --git a/gm/rebaseline_server/static/constants.js b/gm/rebaseline_server/static/constants.js
index 87a07752a35522a14b8dce658bded7f4a9253f5c..ca61dbb3e89e2d0403cbeb65bebdeefe32297bf8 100644
--- a/gm/rebaseline_server/static/constants.js
+++ b/gm/rebaseline_server/static/constants.js
@@ -9,11 +9,13 @@ var module = angular.module(
module.constant('constants', (function() {
return {
// NOTE: Keep these in sync with ../column.py
- KEY__HEADER_TEXT: 'headerText',
- KEY__HEADER_URL: 'headerUrl',
- KEY__IS_FILTERABLE: 'isFilterable',
- KEY__IS_SORTABLE: 'isSortable',
- KEY__VALUES_AND_COUNTS: 'valuesAndCounts',
+ KEY__EXTRACOLUMNHEADERS: 'extraColumnHeaders',
+ KEY__EXTRACOLUMNHEADERS__COUNTS: 'counts',
+ KEY__EXTRACOLUMNHEADERS__HEADER_TEXT: 'headerText',
+ KEY__EXTRACOLUMNHEADERS__HEADER_URL: 'headerUrl',
+ KEY__EXTRACOLUMNHEADERS__IS_FILTERABLE: 'isFilterable',
+ KEY__EXTRACOLUMNHEADERS__IS_SORTABLE: 'isSortable',
+ KEY__EXTRACOLUMNHEADERS__VALUES: 'values',
// NOTE: Keep these in sync with ../imagediffdb.py
KEY__DIFFERENCE_DATA__MAX_DIFF_PER_CHANNEL: 'maxDiffPerChannel',
@@ -31,7 +33,6 @@ module.constant('constants', (function() {
KEY__IS_DIFFERENT: 'isDifferent',
// NOTE: Keep these in sync with ../imagepairset.py
- KEY__EXTRACOLUMNHEADERS: 'extraColumnHeaders',
KEY__IMAGEPAIRS: 'imagePairs',
KEY__IMAGESETS: 'imageSets',
KEY__IMAGESETS__FIELD__BASE_URL: 'baseUrl',
@@ -42,7 +43,7 @@ module.constant('constants', (function() {
KEY__IMAGESETS__SET__WHITEDIFFS: 'whiteDiffs',
// NOTE: Keep these in sync with ../results.py
borenet 2014/05/08 12:40:18 Yikes.
epoger 2014/05/08 15:04:35 The good news is that the comments pointing both w
- REBASELINE_SERVER_SCHEMA_VERSION_NUMBER: 2,
+ REBASELINE_SERVER_SCHEMA_VERSION_NUMBER: 3,
KEY__EXPECTATIONS__BUGS: 'bugs',
KEY__EXPECTATIONS__IGNOREFAILURE: 'ignore-failure',
KEY__EXPECTATIONS__REVIEWED: 'reviewed-by-human',

Powered by Google App Engine
This is Rietveld 408576698