Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2704123003: Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-21T12:50:46 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index bd4b4a333a27266543f56f325565cee56c7b1981..bc9cbfa365676a59609e77c81c7cabdf1227bb1a 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -640,7 +640,10 @@ void SpellChecker::markAndReplaceFor(
int selectionOffset = 0;
int ambiguousBoundaryOffset = -1;
- if (frame().selection().isCaret()) {
+ if (frame()
+ .selection()
+ .computeVisibleSelectionInDOMTreeDeprecated()
+ .isCaret()) {
// TODO(xiaochengh): The following comment does not match the current
// behavior and should be rewritten.
// Attempt to save the caret position so we can restore it later if needed

Powered by Google App Engine
This is Rietveld 408576698