Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 27040003: cc: Fix masks when the RenderPassDrawQuad does not cover the whole pass (Closed)

Created:
7 years, 2 months ago by danakj
Modified:
7 years, 2 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Fix masks when the RenderPassDrawQuad does not cover the whole pass If the RenderPassDrawQuad is not the same size as the texture backing the RenderPass, then we have to scale the texture coordinates when reading the pass texture. If the pass has a mask as well, we have to scale those coordinates as well. However the coordinates given to the mask shader are already scaled to the size of the contents texture. We further scale and offset the coordinates but the offset was incorrect. Tested by: RendererPixelTest.RenderPassAndMaskWithPartialQuad LayerTreeHostMasksPixelTest.MaskOfClippedLayer R=enne BUG=264534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228376

Patch Set 1 #

Patch Set 2 : masks: clearer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -9 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 2 chunks +107 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 2 months ago (2013-10-11 21:17:13 UTC) #1
enne (OOO)
lgtm Thanks for the pixel test!
7 years, 2 months ago (2013-10-11 21:36:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/27040003/5001
7 years, 2 months ago (2013-10-11 21:41:43 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-12 02:38:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/27040003/5001
7 years, 2 months ago (2013-10-12 15:09:31 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-12 19:51:48 UTC) #6
Message was sent while issue was closed.
Change committed as 228376

Powered by Google App Engine
This is Rietveld 408576698