Update in-process Devtools permission to be for each specific extension origin

Currently, if a browser has one Devtools Chrome extension installed, all chrome extensions are given permission to be rendered in the same process as devtools.  Instead, each individual extension should be granted permission for its origin.

This is intended to be part of a greater bug fix for implementing OOPIFs within Devtools Extensions correctly.  See the bug below.

BUG=570483
Review-Url: https://codereview.chromium.org/2703963002
Cr-Commit-Position: refs/heads/master@{#452290}
Committed: https://chromium.googlesource.com/chromium/src/+/8bad2c7e2500efc916a03dc146c01909cd1a757a

[davidsac (gone - try alexmos), 2017-02-18 01:11:00]

The CQ bit was checked by davidsac@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 01:11:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidsac (gone - try alexmos), 2017-02-18 01:13:36]

Description was changed from

==========
change |GrantScheme| to |GrantOrigin|

BUG=570483
==========

to

==========
change |GrantScheme| to |GrantOrigin|

BUG=570483
==========

[davidsac (gone - try alexmos), 2017-02-18 01:19:02]

Description was changed from

==========
change |GrantScheme| to |GrantOrigin|

BUG=570483
==========

to

==========
Currently, if a browser has one Devtools Chrome extension installed, all chrome
extensions are given permission to be rendered in the same process as devtools. 
Instead, each individual extension should be granted permission for its origin.

BUG=570483
==========

[davidsac (gone - try alexmos), 2017-02-18 01:20:08]

Description was changed from

==========
Currently, if a browser has one Devtools Chrome extension installed, all chrome
extensions are given permission to be rendered in the same process as devtools. 
Instead, each individual extension should be granted permission for its origin.

BUG=570483
==========

to

==========
Currently, if a browser has one Devtools Chrome extension installed, all chrome
extensions are given permission to be rendered in the same process as devtools. 
Instead, each individual extension should be granted permission for its origin.

This is intended to be part of a greater bug fix for implementing OOPIFs within
Devtools Extensions correctly.  See the bug below.

BUG=570483
==========

[davidsac (gone - try alexmos), 2017-02-18 01:27:22]

davidsac@chromium.org changed reviewers:
+ alexmos@chromium.org, creis@chromium.org, nick@chromium.org

[davidsac (gone - try alexmos), 2017-02-18 01:27:23]

Hi Charlie and Nick,

I've made a first attempt at the proposed solution for implementing a fix for
OOPIFs within devtools Extensions.  Please take a look and let me know what you
think!

[commit-bot: I haz the power, 2017-02-18 03:14:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:14:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[ncarter (slow), 2017-02-22 19:20:06]

lgtm

https://codereview.chromium.org/2703963002/diff/1/chrome/browser/devtools/dev...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/2703963002/diff/1/chrome/browser/devtools/dev...
chrome/browser/devtools/devtools_ui_bindings.cc:1271:
url::Origin(extension.get()->url()));
extension.get()->url()

can be simplified to

extension->url()

[davidsac (gone - try alexmos), 2017-02-22 20:09:47]

The CQ bit was checked by davidsac@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:10:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:23:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:23:08]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[davidsac (gone - try alexmos), 2017-02-22 21:34:29]

The CQ bit was checked by davidsac@chromium.org to run a CQ dry run

[davidsac (gone - try alexmos), 2017-02-22 21:34:54]

The nit has been fixed

https://codereview.chromium.org/2703963002/diff/1/chrome/browser/devtools/dev...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/2703963002/diff/1/chrome/browser/devtools/dev...
chrome/browser/devtools/devtools_ui_bindings.cc:1271:
url::Origin(extension.get()->url()));
On 2017/02/22 19:20:06, ncarter wrote:
> extension.get()->url()
> 
> can be simplified to
> 
> extension->url()

Done.

[davidsac (gone - try alexmos), 2017-02-22 21:34:57]

The nit has been fixed.

[davidsac (gone - try alexmos), 2017-02-22 21:35:41]

davidsac@chromium.org changed reviewers:
+ dgozman@chromium.org

[davidsac (gone - try alexmos), 2017-02-22 21:35:42]

Hi dgozman,

Could you please review this changelist for OWNER approval?

[commit-bot: I haz the power, 2017-02-22 21:35:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-02-22 21:46:52]

lgtm

[commit-bot: I haz the power, 2017-02-22 22:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:34:37]

Dry run: This issue passed the CQ dry run.

[davidsac (gone - try alexmos), 2017-02-22 23:55:12]

The CQ bit was checked by davidsac@chromium.org

[davidsac (gone - try alexmos), 2017-02-22 23:55:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2703963002/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2017-02-22 23:57:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:07:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487807712890440,
"parent_rev": "c59596d13ec0e105c72dd69661b8bcb505d9afa7", "commit_rev":
"8bad2c7e2500efc916a03dc146c01909cd1a757a"}

[commit-bot: I haz the power, 2017-02-23 00:08:17]

Description was changed from

==========
Currently, if a browser has one Devtools Chrome extension installed, all chrome
extensions are given permission to be rendered in the same process as devtools. 
Instead, each individual extension should be granted permission for its origin.

This is intended to be part of a greater bug fix for implementing OOPIFs within
Devtools Extensions correctly.  See the bug below.

BUG=570483
==========

to

==========
Currently, if a browser has one Devtools Chrome extension installed, all chrome
extensions are given permission to be rendered in the same process as devtools. 
Instead, each individual extension should be granted permission for its origin.

This is intended to be part of a greater bug fix for implementing OOPIFs within
Devtools Extensions correctly.  See the bug below.

BUG=570483

Review-Url: https://codereview.chromium.org/2703963002
Cr-Commit-Position: refs/heads/master@{#452290}
Committed:
https://chromium.googlesource.com/chromium/src/+/8bad2c7e2500efc916a03dc146c0...
==========

[commit-bot: I haz the power, 2017-02-23 00:08:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8bad2c7e2500efc916a03dc146c0...