Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2703943002: Cap the delay time for the main job when racing with QUIC for delayed tcp case so that if http_serv… (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Cap the delay time for the main job when racing with QUIC for delayed tcp case so that if http_server_properties has cached a inappropriate srtt will not block the main job for a extremely long time. BUG=691688 Review-Url: https://codereview.chromium.org/2690393005 Cr-Commit-Position: refs/heads/master@{#451066} (cherry picked from commit 326a7fdb3a840dd926b4b4ff14ca7fe24d87ffc0) R=rch@chromium.org Review-Url: https://codereview.chromium.org/2703943002 . Cr-Commit-Position: refs/branch-heads/2987@{#586} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8b44f98e742ec88474cadfce805f44f59da49800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -27 lines) Patch
M net/http/http_stream_factory_impl_job_controller.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 6 chunks +89 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Zhongyi Shi
Built and tested on local release branch.
3 years, 10 months ago (2017-02-18 00:21:19 UTC) #2
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-18 00:33:08 UTC) #3
Zhongyi Shi
3 years, 10 months ago (2017-02-18 00:34:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b44f98e742ec88474cadfce805f44f59da49800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698