LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html - Issue 27039002: Fix crash when the OfflineAudioContext constructor is given 0 as numberOfFrames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html

Issue 27039002: Fix crash when the OfflineAudioContext constructor is given 0 as numberOfFrames (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html

diff --git a/LayoutTests/crypto/worker-random-values-types.html b/LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html

similarity index 54%

copy from LayoutTests/crypto/worker-random-values-types.html

copy to LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html

index 1b6ff3cecfea7fb1203c415da00de8e8ceca401f..75b43ec027db3d54fff49376f7429ff5c034339a 100644

--- a/LayoutTests/crypto/worker-random-values-types.html

+++ b/LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html

@@ -4,10 +4,11 @@

</head>

<body>

-<p id="description"></p>

-<div id="console"></div>

- worker = startWorker("resources/random-values-types.js");

+description("Checks that the OfflineAudioContext does not crash on bad input");

Raymond Toy (Google) 2013/10/11 20:04:40 I think this file should not include "crash" in th

Inactive 2013/10/11 20:48:18 Done.

+// 0 as number of frames.

+shouldThrow("new webkitOfflineAudioContext(0, 0, 46000)");

Raymond Toy (Google) 2013/10/11 20:04:40 Why 46000 for the sample rate? I would choose a mo

Inactive 2013/10/11 20:48:18 Done.

</script>

</body>

« no previous file with comments | « no previous file | LayoutTests/webaudio/offlineaudiocontext-constructor-crash-expected.txt » ('j') | Source/modules/webaudio/AudioContext.cpp » ('J')