LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html - Issue 27039002: Fix crash when the OfflineAudioContext constructor is given 0 as numberOfFrames

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/webaudio/offlineaudiocontext-constructor-crash.html

Issue 27039002: Fix crash when the OfflineAudioContext constructor is given 0 as numberOfFrames (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../fast/js/resources/js-test-pre.js"></script>	4 <script src="../fast/js/resources/js-test-pre.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <p id="description"></p>

8 <div id="console"></div>

9 <script>	7 <script>

10 worker = startWorker("resources/random-values-types.js");	8 description("Checks that the OfflineAudioContext does not crash on bad input");
	Raymond Toy (Google) 2013/10/11 20:04:40 I think this file should not include "crash" in th I think this file should not include "crash" in the name. Maybe name it offlineaudiocontext-constructor.html. The description probably should not say crash either. Inactive 2013/10/11 20:48:18 Done. Show quoted text On 2013/10/11 20:04:40, rtoy wrote: > I think this file should not include "crash" in the name. Maybe name it > offlineaudiocontext-constructor.html. The description probably should not say > crash either. Done.
	9

	10 // 0 as number of frames.

	11 shouldThrow("new webkitOfflineAudioContext(0, 0, 46000)");
	Raymond Toy (Google) 2013/10/11 20:04:40 Why 46000 for the sample rate? I would choose a mo Why 46000 for the sample rate? I would choose a more typical value like 44100. Also, it's not clear what 0 channels should do for an offline context. (Spec doesn't say). So to be safe, I would use 1 channel. Inactive 2013/10/11 20:48:18 Done. Show quoted text On 2013/10/11 20:04:40, rtoy wrote: > Why 46000 for the sample rate? I would choose a more typical value like 44100. > > Also, it's not clear what 0 channels should do for an offline context. (Spec > doesn't say). So to be safe, I would use 1 channel. Done.
11 </script>	12 </script>

12 <script src="../fast/js/resources/js-test-post.js"></script>	13 <script src="../fast/js/resources/js-test-post.js"></script>

13 </body>	14 </body>

14 </html>	15 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/webaudio/offlineaudiocontext-constructor-crash-expected.txt » ('j') | Source/modules/webaudio/AudioContext.cpp » ('J')