[Mac RTL] Correctly position icons and fade text for RTL.

[Mac RTL] Correctly position icons and fade text for RTL.

Note that while icon positioning depends on the RTLness of the browser, fading of RTL text always happens. We always correctly fade RTL text (see -[TabView setTitle:]) and we should do so on drags.

BUG=693321
TEST=as in bug

Review-Url: https://codereview.chromium.org/2703863004
Cr-Commit-Position: refs/heads/master@{#451436}
Committed: https://chromium.googlesource.com/chromium/src/+/7c0ecf945d1514a474eb184587112cd7f50b7e9d

[Avi (use Gerrit), 2017-02-18 01:15:12]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 01:16:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-02-18 01:38:27]

avi@chromium.org changed reviewers:
+ erikchen@chromium.org

[Avi (use Gerrit), 2017-02-18 01:38:28]

https://codereview.chromium.org/2703863004/diff/1/chrome/browser/ui/cocoa/dra...
File chrome/browser/ui/cocoa/drag_util.h (right):

https://codereview.chromium.org/2703863004/diff/1/chrome/browser/ui/cocoa/dra...
chrome/browser/ui/cocoa/drag_util.h:29: CGFloat drag_image_width);
FYI, this parameter has always been the total max width allowed for the entire
drag image, not just the title part. It was misnamed.

[erikchen, 2017-02-18 01:56:25]

lgtm

https://codereview.chromium.org/2703863004/diff/1/chrome/browser/ui/cocoa/dra...
File chrome/browser/ui/cocoa/drag_util.mm (right):

https://codereview.chromium.org/2703863004/diff/1/chrome/browser/ui/cocoa/dra...
chrome/browser/ui/cocoa/drag_util.mm:64: void DrawTruncatedTitle(const
base::string16& title16,
I was a little bit confused about why you needed both title16 and title. Pehraps
you could just pass in base::i18n::GetFirstStrongCharacterDirection(title16)?

[Avi (use Gerrit), 2017-02-18 02:17:00]

https://codereview.chromium.org/2703863004/diff/1/chrome/browser/ui/cocoa/dra...
File chrome/browser/ui/cocoa/drag_util.mm (right):

https://codereview.chromium.org/2703863004/diff/1/chrome/browser/ui/cocoa/dra...
chrome/browser/ui/cocoa/drag_util.mm:64: void DrawTruncatedTitle(const
base::string16& title16,
On 2017/02/18 01:56:25, erikchen wrote:
> I was a little bit confused about why you needed both title16 and title.
Pehraps
> you could just pass in base::i18n::GetFirstStrongCharacterDirection(title16)?

Done.

[Avi (use Gerrit), 2017-02-18 02:18:08]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-02-18 02:18:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2703863004/#ps20001
(title: "pass just the bool")

[commit-bot: I haz the power, 2017-02-18 02:18:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 04:19:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 04:19:54]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Avi (use Gerrit), 2017-02-18 06:14:36]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-02-18 06:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 07:00:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487398476144130,
"parent_rev": "0ae0fc0d329ac9dea0ca7316eb6515dd817f0166", "commit_rev":
"7c0ecf945d1514a474eb184587112cd7f50b7e9d"}

[commit-bot: I haz the power, 2017-02-18 07:00:47]

Description was changed from

==========
[Mac RTL] Correctly position icons and fade text for RTL.

Note that while icon positioning depends on the RTLness of the browser, fading
of RTL text always happens. We always correctly fade RTL text (see -[TabView
setTitle:]) and we should do so on drags.

BUG=693321
TEST=as in bug
==========

to

==========
[Mac RTL] Correctly position icons and fade text for RTL.

Note that while icon positioning depends on the RTLness of the browser, fading
of RTL text always happens. We always correctly fade RTL text (see -[TabView
setTitle:]) and we should do so on drags.

BUG=693321
TEST=as in bug

Review-Url: https://codereview.chromium.org/2703863004
Cr-Commit-Position: refs/heads/master@{#451436}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c0ecf945d1514a474eb18458711...
==========

[commit-bot: I haz the power, 2017-02-18 07:00:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c0ecf945d1514a474eb18458711...