|
|
Chromium Code Reviews
DescriptionMD Settings: change view report string to make more sense.
BUG=692441
Review-Url: https://codereview.chromium.org/2703863002
Cr-Commit-Position: refs/heads/master@{#451904}
Committed: https://chromium.googlesource.com/chromium/src/+/f86a6616219c1062c21e3255e28b0ee1bb7d8305
Patch Set 1 #Patch Set 2 : remove accidental dependent CL #Patch Set 3 : rebase #Messages
Total messages: 21 (11 generated)
scottchen@chromium.org changed reviewers: + dpapad@chromium.org
lgtm
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for chrome/app/settings_strings.grdp:
While running git apply --index -p1;
error: patch failed: chrome/app/settings_strings.grdp:1622
error: chrome/app/settings_strings.grdp: patch does not apply
Patch: chrome/app/settings_strings.grdp
Index: chrome/app/settings_strings.grdp
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
index
7ca49fdf180c23865b48f0c3d458c1a431496f29..38c2910920d34c87c3d739dee126a2c2582b3d96
100644
--- a/chrome/app/settings_strings.grdp
+++ b/chrome/app/settings_strings.grdp
@@ -1622,7 +1622,7 @@
Reset
</message>
<message name="IDS_SETTINGS_RESET_VIEW_REPORTED_SETTINGS" desc="Label of a
link that when clicked displays the settings that will be reported to Google for
analysis.">
- View report settings
+ View report
</message>
<!-- Search Page -->
The CQ bit was checked by scottchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2703863002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487746726193180,
"parent_rev": "6923513dcedf4c6b55bc923fc0146aff71b3da46", "commit_rev":
"f86a6616219c1062c21e3255e28b0ee1bb7d8305"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: change view report string to make more sense. BUG=692441 ========== to ========== MD Settings: change view report string to make more sense. BUG=692441 Review-Url: https://codereview.chromium.org/2703863002 Cr-Commit-Position: refs/heads/master@{#451904} Committed: https://chromium.googlesource.com/chromium/src/+/f86a6616219c1062c21e3255e28b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f86a6616219c1062c21e3255e28b... |
