Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Issue 2703823002: Record scroll_layer_id instead of scrollbar_animation_controller pointer (Closed)

Created:
3 years, 10 months ago by chaopeng
Modified:
3 years, 10 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record scroll_layer_id_mouse_currently_captured_ instead of captured_scrollbar_animation_controller_ pointer This issue is caused by the mouse down can change size and make |captured_scrollbar_animation_controller_| to be a dangling pointer. So we should record the scroll_layer id and find the animation_controller in each MouseUp call. BUG=693414 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2703823002 Cr-Commit-Position: refs/heads/master@{#451828} Committed: https://chromium.googlesource.com/chromium/src/+/ff8e6a1d5aef75e6c0a8b87fc16c11d5cb69edac

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M cc/trees/layer_tree_host_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 3 chunks +12 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
chaopeng
PTAL. Thank you.
3 years, 10 months ago (2017-02-17 17:44:20 UTC) #4
weiliangc
LGTM
3 years, 10 months ago (2017-02-21 16:52:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703823002/20001
3 years, 10 months ago (2017-02-21 18:01:36 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 20:14:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff8e6a1d5aef75e6c0a8b87fc16c...

Powered by Google App Engine
This is Rietveld 408576698