Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2703803003: Use unique id's in svg/filters/feBlend-all-modes.html (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unique id's in svg/filters/feBlend-all-modes.html The same id's would be reused in all the three groups (color combinations.) Add the group index to the id's to avoid this. BUG=454767 Review-Url: https://codereview.chromium.org/2703803003 Cr-Commit-Position: refs/heads/master@{#451483} Committed: https://chromium.googlesource.com/chromium/src/+/4ed8b41d5e7e3b6cbf292f3a8d3533b767fd0417

Patch Set 1 #

Patch Set 2 : Updated expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -195 lines) Patch
M third_party/WebKit/LayoutTests/platform/linux/svg/filters/feBlend-all-modes-expected.txt View 1 1 chunk +96 lines, -96 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/filters/feBlend-all-modes.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/filters/feBlend-all-modes-expected.txt View 1 1 chunk +96 lines, -96 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 10 months ago (2017-02-18 07:59:23 UTC) #6
pdr.
On 2017/02/18 at 07:59:23, fs wrote: > LGTM
3 years, 10 months ago (2017-02-18 18:33:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703803003/20001
3 years, 10 months ago (2017-02-18 18:40:12 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 18:44:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ed8b41d5e7e3b6cbf292f3a8d35...

Powered by Google App Engine
This is Rietveld 408576698