[IOS Reading List] Change handling of distillation error.

[IOS Reading List] Change handling of distillation error.

New behavior:
- No single error is permanent.
- After 6 tries, we report permanent error and do not retry.

BUG=693503
Review-Url: https://codereview.chromium.org/2703773002
Cr-Commit-Position: refs/heads/master@{#451638}
Committed: https://chromium.googlesource.com/chromium/src/+/bd693b9640181dcad2c8cda05ad82bcfd46a8398

[Olivier, 2017-02-17 14:02:40]

olivierrobin@chromium.org changed reviewers:
+ gambard@chromium.org

[gambard, 2017-02-17 14:07:47]

ReadingListDownloadService might use some refactoring ;)

https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/reading_list_download_service.cc (right):

https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_download_service.cc:269: if
(will_retry) {
Why this is not merged with the metrics?
Is there a reason to schedule the download/set the state of a non-existing
entry?

https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_download_service.cc:278: // Catch
if another status is added.
Use a switch?

[Olivier, 2017-02-17 14:27:15]

https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/reading_list_download_service.cc (right):

https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_download_service.cc:269: if
(will_retry) {
On 2017/02/17 14:07:47, gambard wrote:
> Why this is not merged with the metrics?
> Is there a reason to schedule the download/set the state of a non-existing
> entry?

It is not merged precisely to not retry if entry does not exist :)
Merged using && precedence

https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_download_service.cc:278: // Catch
if another status is added.
On 2017/02/17 14:07:47, gambard wrote:
> Use a switch?

Done.

[gambard, 2017-02-20 07:41:22]

lgtm

[Olivier, 2017-02-20 16:37:34]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-02-20 16:37:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 16:49:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487608654424840,
"parent_rev": "9eaef2f85417dfc5fbe6df92ca1ccbacaeefad92", "commit_rev":
"bd693b9640181dcad2c8cda05ad82bcfd46a8398"}

[commit-bot: I haz the power, 2017-02-20 16:50:04]

Description was changed from

==========
[IOS Reading List] Change handling of distillation error.

New behavior:
- No single error is permanent.
- After 6 tries, we report permanent error and do not retry.

BUG=693503
==========

to

==========
[IOS Reading List] Change handling of distillation error.

New behavior:
- No single error is permanent.
- After 6 tries, we report permanent error and do not retry.

BUG=693503

Review-Url: https://codereview.chromium.org/2703773002
Cr-Commit-Position: refs/heads/master@{#451638}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd693b9640181dcad2c8cda05ad8...
==========

[commit-bot: I haz the power, 2017-02-20 16:50:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bd693b9640181dcad2c8cda05ad8...