Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2703773002: [IOS Reading List] Change handling of distillation error. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[IOS Reading List] Change handling of distillation error. New behavior: - No single error is permanent. - After 6 tries, we report permanent error and do not retry. BUG=693503 Review-Url: https://codereview.chromium.org/2703773002 Cr-Commit-Position: refs/heads/master@{#451638} Committed: https://chromium.googlesource.com/chromium/src/+/bd693b9640181dcad2c8cda05ad82bcfd46a8398

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -44 lines) Patch
M ios/chrome/browser/reading_list/reading_list_download_service.cc View 1 1 chunk +33 lines, -30 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.cc View 5 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Olivier
3 years, 10 months ago (2017-02-17 14:02:41 UTC) #2
gambard
ReadingListDownloadService might use some refactoring ;) https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_list/reading_list_download_service.cc File ios/chrome/browser/reading_list/reading_list_download_service.cc (right): https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_list/reading_list_download_service.cc#newcode269 ios/chrome/browser/reading_list/reading_list_download_service.cc:269: if (will_retry) { ...
3 years, 10 months ago (2017-02-17 14:07:47 UTC) #3
Olivier
https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_list/reading_list_download_service.cc File ios/chrome/browser/reading_list/reading_list_download_service.cc (right): https://codereview.chromium.org/2703773002/diff/1/ios/chrome/browser/reading_list/reading_list_download_service.cc#newcode269 ios/chrome/browser/reading_list/reading_list_download_service.cc:269: if (will_retry) { On 2017/02/17 14:07:47, gambard wrote: > ...
3 years, 10 months ago (2017-02-17 14:27:15 UTC) #4
gambard
lgtm
3 years, 10 months ago (2017-02-20 07:41:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703773002/20001
3 years, 10 months ago (2017-02-20 16:37:51 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 16:50:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bd693b9640181dcad2c8cda05ad8...

Powered by Google App Engine
This is Rietveld 408576698