Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2703673002: [Merge-57] Add billing_address_id and has_converted to autofill_table (Closed)

Created:
3 years, 10 months ago by sebsg
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge-57] Add billing_address_id and has_converted to autofill_table Adds the billing_address_id column to the server_card_metadata table and add the has_converted column to the server_address_metadata table in autofill_table. This CL does not modify any user noticeable behavior but is a stepping stone towards converting Wallet addresses to Autofill profiles and preserving the billing address relation ship. Both fields were added to the metadata tables, because those are intended to be read-write and used to sync this modifiable info across Chrome instances. BUG=680178 Review-Url: https://codereview.chromium.org/2626843004 Cr-Commit-Position: refs/heads/master@{#445949} (cherry picked from commit 3e77d95a76768a00bfb8cffc4799b52e640c1ae7) Review-Url: https://codereview.chromium.org/2703673002 . Cr-Commit-Position: refs/branch-heads/2987@{#556} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/6cbfc336157c5b779815d95e153be12c8e9b0942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -183 lines) Patch
M components/autofill/core/browser/personal_data_manager.cc View 3 chunks +4 lines, -19 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.h View 6 chunks +11 lines, -8 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 14 chunks +109 lines, -55 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 6 chunks +8 lines, -30 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata.h View 1 chunk +4 lines, -9 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h View 1 chunk +4 lines, -10 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 3 chunks +4 lines, -21 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.cc View 1 chunk +6 lines, -16 lines 0 comments Download
A components/test/data/web_database/version_70.sql View 1 chunk +34 lines, -0 lines 0 comments Download
M components/webdata/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 4 chunks +84 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sebsg
3 years, 10 months ago (2017-02-16 20:37:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cbfc336157c5b779815d95e153be12c8e9b0942.

Powered by Google App Engine
This is Rietveld 408576698