content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret. (Closed)

Patch Set: Reworked the core code to always return an ACK and check for a null frame. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/view_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/SelectionClient.java » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 12672fc9e7fade105dabff40a59f2f737eed9abf..ade428c834a0415b8dae71e1dd3c8d4b03259198 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -885,6 +885,12 @@ public class ContentViewCore

mSelectionPopupController.onShowUnhandledTapUIIfNeeded(x, y);

}

+ @SuppressWarnings("unused")

+ @CalledByNative

+ private void onSelectWordAroundCaretAck(boolean didSelect, int startAdjust, int endAdjust) {

+ mSelectionPopupController.onSelectWordAroundCaretAck(didSelect, startAdjust, endAdjust);

+ }

/**

* Called just prior to a tap or press gesture being forwarded to the renderer.