content/common/view_messages.h - Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret. (Closed)

Patch Set: Reworked the core code to always return an ACK and check for a null frame. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index cf32fe699180940210edd4e2b48791edd3e54a6f..62aff1b8f0af36f6d0996e6401b5042cdf5bc4fd 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -869,6 +869,13 @@ IPC_MESSAGE_ROUTED0(ViewHostMsg_DidFirstVisuallyNonEmptyPaint)

// Sent in reply to ViewMsg_WaitForNextFrameForTests.

IPC_MESSAGE_ROUTED0(ViewHostMsg_WaitForNextFrameForTests_ACK)

+// Acknowledges that a SelectWordAroundCaret completed with the specified

+// result and adjustments to the selection offsets.

+IPC_MESSAGE_ROUTED3(ViewHostMsg_SelectWordAroundCaretAck,

+ bool /* did_select */,

+ int /* start_adjust */,

+ int /* end_adjust */)

#if defined(OS_ANDROID)

// Notifies that an unhandled tap has occurred at the specified x,y position

// and that the UI may need to be triggered.