Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2703633005: [tab_grid] Hack-in close tab. (Closed)

Created:
3 years, 10 months ago by edchin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tab_grid] Hack-in close tab. BUG=686770 Review-Url: https://codereview.chromium.org/2703633005 Cr-Commit-Position: refs/heads/master@{#451642} Committed: https://chromium.googlesource.com/chromium/src/+/ec7f2777385a8a84d4cb03ebf077240b7f70e41b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M ios/clean/chrome/browser/ui/commands/tab_commands.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm View 1 chunk +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
edchin
3 years, 10 months ago (2017-02-20 00:49:45 UTC) #2
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-20 10:11:10 UTC) #4
jif
lgtm
3 years, 10 months ago (2017-02-20 16:54:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703633005/1
3 years, 10 months ago (2017-02-20 17:10:32 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 17:22:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec7f2777385a8a84d4cb03ebf077...

Powered by Google App Engine
This is Rietveld 408576698