Add initial BUILD.gn in platform/wtf/, and move first a few files there.

Add initial BUILD.gn in platform/wtf/, and move first a few files there.

This is the first attempt to move files in wtf/ to platform/wtf/. In this
commit, initial BUILD.gn is introduced in platform/wtf/, and the following
files are moved to platform/wtf/ as a proof that the new BUILD.gn actually
works.

The following files are moved at this time:
    WTFExport.h
    CryptographicallyRandomNumber.{h,cpp}

They are chosen because they have very minimum dependency on other files
in wtf/, and we need at least one cpp file to make the target linkable.

BUG=691465
Review-Url: https://codereview.chromium.org/2703633003
Cr-Commit-Position: refs/heads/master@{#455410}
Committed: https://chromium.googlesource.com/chromium/src/+/00b8333a75c81b89aec8a377a33fa071a59e1748

[Yuta Kitamura, 2017-02-17 08:15:28]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 08:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-02-17 09:04:14]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuta Kitamura, 2017-02-17 09:04:15]

PTAL

[commit-bot: I haz the power, 2017-02-17 09:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 09:42:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-02-17 10:37:24]

LGTM

https://codereview.chromium.org/2703633003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/BUILD.gn (right):

https://codereview.chromium.org/2703633003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/BUILD.gn:15: # only redirection headers
in wtf/ to include the headers in "platform/wtf".

But it's fine to use platform_wtf from core/, modules/ etc, right?

I think the restriction here is that platform_wtf should not use any other
platform/ things until we break the dependency from wtf to platform_wtf.

[Yuta Kitamura, 2017-02-17 11:35:52]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2017-02-17 11:35:53]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2703633003/#ps20001
(title: "Fix comments about visibility.")

[commit-bot: I haz the power, 2017-02-17 11:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-02-17 11:41:06]

https://codereview.chromium.org/2703633003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/BUILD.gn (right):

https://codereview.chromium.org/2703633003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/BUILD.gn:15: # only redirection headers
in wtf/ to include the headers in "platform/wtf".
On 2017/02/17 10:37:24, haraken wrote:
> 
> But it's fine to use platform_wtf from core/, modules/ etc, right?
> 
> I think the restriction here is that platform_wtf should not use any other
> platform/ things until we break the dependency from wtf to platform_wtf.

Yeah, I think you are right. Both gn-wise and DEPS-wise, there's
nothing that blocks including from core/ or modules/. I'll correct
the comments.

[commit-bot: I haz the power, 2017-02-17 13:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 13:12:46]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Nico, 2017-02-17 16:06:16]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-17 16:06:17]

The win_clang failure here is real I think: cl and gcc will pick up different
WTFExport.h headers for these includes. (The presenter notes of the slides at
https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ...
have some details on this)

[Yuta Kitamura, 2017-02-20 07:52:40]

On 2017/02/17 16:06:17, Nico wrote:
> The win_clang failure here is real I think: cl and gcc will pick up different
> WTFExport.h headers for these includes. (The presenter notes of the slides at
>
https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ...
> have some details on this)

OK, we probably need to rename platform/wtf to something else
due to MSVC-specific include rules...

Will create another CL to just do the directory rename, and then
try to land this again.
in_reply_to: 5754903989321728
send_mail: 1
subject: Add initial BUILD.gn in platform/wtf/, and move first a few files
there.

[Yuta Kitamura, 2017-02-20 10:58:28]

Patchset #3 (id:40001) has been deleted

[Yuta Kitamura, 2017-02-20 11:03:17]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 11:03:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-02-20 11:04:01]

haraken: PTAL again at this one? I think this should be fine.

https://codereview.chromium.org/2703633003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h
(right):

https://codereview.chromium.org/2703633003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h:28:
#define CryptographicallyRandomNumber_h
WebKit lint warned #include guard style this time; maybe there's some
special rules for files under */wtf/?

[haraken, 2017-02-20 11:58:26]

LGTM

https://codereview.chromium.org/2703633003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h
(right):

https://codereview.chromium.org/2703633003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h:28:
#define CryptographicallyRandomNumber_h
On 2017/02/20 11:04:00, Yuta Kitamura wrote:
> WebKit lint warned #include guard style this time; maybe there's some
> special rules for files under */wtf/?

Hmm, I'm not sure.

[commit-bot: I haz the power, 2017-02-20 12:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 12:25:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-02-20 14:04:45]

Just adding more -I flags instead of renaming will probably do the trick as
well. (On phone, but can give a amore detailed suggestion later if you want)

On Feb 20, 2017 6:58 AM, <haraken@chromium.org> wrote:

> LGTM
>
>
>
> https://codereview.chromium.org/2703633003/diff/60001/
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h
> File
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h
> (right):
>
> https://codereview.chromium.org/2703633003/diff/60001/
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.
> h#newcode28
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.
> h:28:
> #define CryptographicallyRandomNumber_h
> On 2017/02/20 11:04:00, Yuta Kitamura wrote:
> > WebKit lint warned #include guard style this time; maybe there's some
> > special rules for files under */wtf/?
>
> Hmm, I'm not sure.
>
> https://codereview.chromium.org/2703633003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2017-02-20 14:04:45]

Just adding more -I flags instead of renaming will probably do the trick as
well. (On phone, but can give a amore detailed suggestion later if you want)

On Feb 20, 2017 6:58 AM, <haraken@chromium.org> wrote:

> LGTM
>
>
>
> https://codereview.chromium.org/2703633003/diff/60001/
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h
> File
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.h
> (right):
>
> https://codereview.chromium.org/2703633003/diff/60001/
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.
> h#newcode28
> third_party/WebKit/Source/platform/newwtf/CryptographicallyRandomNumber.
> h:28:
> #define CryptographicallyRandomNumber_h
> On 2017/02/20 11:04:00, Yuta Kitamura wrote:
> > WebKit lint warned #include guard style this time; maybe there's some
> > special rules for files under */wtf/?
>
> Hmm, I'm not sure.
>
> https://codereview.chromium.org/2703633003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yuta Kitamura, 2017-02-21 01:06:01]

On 2017/02/20 14:04:45, Nico wrote:
> Just adding more -I flags instead of renaming will probably do the trick as
> well. (On phone, but can give a amore detailed suggestion later if you want)
> 

I'm interested. Can you give me further info when you have time?
Thanks!

[Yuta Kitamura, 2017-02-21 01:08:51]

On 2017/02/21 01:06:01, Yuta Kitamura wrote:
> On 2017/02/20 14:04:45, Nico wrote:
> > Just adding more -I flags instead of renaming will probably do the trick as
> > well. (On phone, but can give a amore detailed suggestion later if you want)
> > 
> 
> I'm interested. Can you give me further info when you have time?
> Thanks!

FYI, //third_party/WebKit/Source:config seemed right to me,
but is there any trick here? Or put another config elsewhere?

[Yuta Kitamura, 2017-02-22 10:54:11]

On 2017/02/21 01:08:51, Yuta Kitamura wrote:
> On 2017/02/21 01:06:01, Yuta Kitamura wrote:
> > On 2017/02/20 14:04:45, Nico wrote:
> > > Just adding more -I flags instead of renaming will probably do the trick
as
> > > well. (On phone, but can give a amore detailed suggestion later if you
want)
> > > 
> > 
> > I'm interested. Can you give me further info when you have time?
> > Thanks!
> 
> FYI, //third_party/WebKit/Source:config seemed right to me,
> but is there any trick here? Or put another config elsewhere?

Hey Nico, I'm still curious about this. (hoping this post will
bump the thread in your email queue...)

[Nico, 2017-02-22 15:20:03]

On 2017/02/22 10:54:11, Yuta Kitamura wrote:
> On 2017/02/21 01:08:51, Yuta Kitamura wrote:
> > On 2017/02/21 01:06:01, Yuta Kitamura wrote:
> > > On 2017/02/20 14:04:45, Nico wrote:
> > > > Just adding more -I flags instead of renaming will probably do the trick
> as
> > > > well. (On phone, but can give a amore detailed suggestion later if you
> want)
> > > > 
> > > 
> > > I'm interested. Can you give me further info when you have time?
> > > Thanks!
> > 
> > FYI, //third_party/WebKit/Source:config seemed right to me,
> > but is there any trick here? Or put another config elsewhere?
> 
> Hey Nico, I'm still curious about this. (hoping this post will
> bump the thread in your email queue...)

Sorry about dropping the ball here.

From looking around a bit, Source:config gets added here
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/core.gni?...
to blink_core_sources targets.  The error is:

FAILED:
obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl/ClipboardEventInit.obj

E:\b\c\cipd\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl/ClipboardEventInit.obj.rsp
/c gen/blink/core/events/ClipboardEventInit.cpp
/Foobj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl/ClipboardEventInit.obj
/Fd"obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl_cc.pdb"
In file included from gen/blink/core/events/ClipboardEventInit.cpp:14:
In file included from
../../third_party/WebKit/Source\core/clipboard/DataTransfer.h:30:
In file included from
../../third_party/WebKit/Source\core/loader/resource/ImageResourceContent.h:11:
In file included from
../../third_party/WebKit/Source\platform/geometry/LayoutSize.h:34:
In file included from ../../third_party/WebKit/Source\platform/LayoutUnit.h:39:
E:\b\c\b\win_clang\src\third_party\WebKit\Source\wtf\text\WTFString.h(32,10): 
error: #include resolved using non-portable Microsoft search rules as:
../../third_party/WebKit/Source\platform/wtf/WTFExport.h
[-Werror,-Wmicrosoft-include]
#include "wtf/WTFExport.h"

So it happens when building ClipboardEventInit.obj which is part of the
bindings_core_impl target, which as far as I can tell does use
blink_core_sources:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...

So I agree with you that it's a bit surprising that this doesn't work. Let me
patch this in on my windows box and take a look. I'll reply within 2h with my
findings.

[Nico, 2017-02-22 16:07:32]

Just syncing my windows box took like 25 minutes :-( Anyhow, this makes things
go:

C:\src\chrome\src>git diff
diff --git a/third_party/WebKit/Source/BUILD.gn
b/third_party/WebKit/Source/BUILD.gn
index ca5d37c..423e32a 100644
--- a/third_party/WebKit/Source/BUILD.gn
+++ b/third_party/WebKit/Source/BUILD.gn
@@ -77,6 +77,24 @@ config("blink_pch") {

 config("config") {
   include_dirs = [
+    # We're in the process of moving wtf from Source/wtf to
Source/platform/wtf.
+    # To make the transition easier, we have some forwarding headers in
+    # Source/wtf, for example Source/wtf/WTFExport.h includes
+    # Source/platform/WTFExport.h.
+    # MSVC adds the directories of all currently included files to the
+    # include search path
+    # (https://msdn.microsoft.com/en-us/library/36k2cdd4.aspx), so if any file
+    # includes any file from platform/, "wtf/WTFExport.h" will refer to
+    # "platform/wtf/WTFExport.h" implicitly with MSVC but to "wtf/WTFExport.h"
+    # with the other compilers. To get consistent behavior across compilers,
+    # explicitly add "platform" to the include search path _before_ '.'. This
+    # way, "wtf/foo.h" will refer to "platform/wtf/foo.h" everywhere. Once
+    # all #include lines are rewritten to refer to "platform/wtf/foo.h"
+    # explicitly, this should be removed again.
+    # TODO(yutak): Remove this once all includes have been rewritten,
+    # https://crbug.com/XXX
+    "platform",
+
     ".",
     "..",
     "$root_gen_dir/blink",


It's not super pretty either, but it seems a lot better than having "newwtf".

[Nico, 2017-02-22 16:43:58]

Another idea would be to do this only on Windows (since it's already
happening there and this would make it explicit). Not sure what's better,
probably doesn't matter too much.

On Feb 22, 2017 11:07 AM, <thakis@chromium.org> wrote:

> Just syncing my windows box took like 25 minutes :-( Anyhow, this makes
> things
> go:
>
> C:\src\chrome\src>git diff
> diff --git a/third_party/WebKit/Source/BUILD.gn
> b/third_party/WebKit/Source/BUILD.gn
> index ca5d37c..423e32a 100644
> --- a/third_party/WebKit/Source/BUILD.gn
> +++ b/third_party/WebKit/Source/BUILD.gn
> @@ -77,6 +77,24 @@ config("blink_pch") {
>
> config("config") {
> include_dirs = [
> + # We're in the process of moving wtf from Source/wtf to
> Source/platform/wtf.
> + # To make the transition easier, we have some forwarding headers in
> + # Source/wtf, for example Source/wtf/WTFExport.h includes
> + # Source/platform/WTFExport.h.
> + # MSVC adds the directories of all currently included files to the
> + # include search path
> + # (https://msdn.microsoft.com/en-us/library/36k2cdd4.aspx), so if any
> file
> + # includes any file from platform/, "wtf/WTFExport.h" will refer to
> + # "platform/wtf/WTFExport.h" implicitly with MSVC but to
> "wtf/WTFExport.h"
> + # with the other compilers. To get consistent behavior across compilers,
> + # explicitly add "platform" to the include search path _before_ '.'. This
> + # way, "wtf/foo.h" will refer to "platform/wtf/foo.h" everywhere. Once
> + # all #include lines are rewritten to refer to "platform/wtf/foo.h"
> + # explicitly, this should be removed again.
> + # TODO(yutak): Remove this once all includes have been rewritten,
> + # https://crbug.com/XXX
> + "platform",
> +
> ".",
> "..",
> "$root_gen_dir/blink",
>
>
> It's not super pretty either, but it seems a lot better than having
> "newwtf".
>
> https://codereview.chromium.org/2703633003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2017-02-22 16:43:59]

Another idea would be to do this only on Windows (since it's already
happening there and this would make it explicit). Not sure what's better,
probably doesn't matter too much.

On Feb 22, 2017 11:07 AM, <thakis@chromium.org> wrote:

> Just syncing my windows box took like 25 minutes :-( Anyhow, this makes
> things
> go:
>
> C:\src\chrome\src>git diff
> diff --git a/third_party/WebKit/Source/BUILD.gn
> b/third_party/WebKit/Source/BUILD.gn
> index ca5d37c..423e32a 100644
> --- a/third_party/WebKit/Source/BUILD.gn
> +++ b/third_party/WebKit/Source/BUILD.gn
> @@ -77,6 +77,24 @@ config("blink_pch") {
>
> config("config") {
> include_dirs = [
> + # We're in the process of moving wtf from Source/wtf to
> Source/platform/wtf.
> + # To make the transition easier, we have some forwarding headers in
> + # Source/wtf, for example Source/wtf/WTFExport.h includes
> + # Source/platform/WTFExport.h.
> + # MSVC adds the directories of all currently included files to the
> + # include search path
> + # (https://msdn.microsoft.com/en-us/library/36k2cdd4.aspx), so if any
> file
> + # includes any file from platform/, "wtf/WTFExport.h" will refer to
> + # "platform/wtf/WTFExport.h" implicitly with MSVC but to
> "wtf/WTFExport.h"
> + # with the other compilers. To get consistent behavior across compilers,
> + # explicitly add "platform" to the include search path _before_ '.'. This
> + # way, "wtf/foo.h" will refer to "platform/wtf/foo.h" everywhere. Once
> + # all #include lines are rewritten to refer to "platform/wtf/foo.h"
> + # explicitly, this should be removed again.
> + # TODO(yutak): Remove this once all includes have been rewritten,
> + # https://crbug.com/XXX
> + "platform",
> +
> ".",
> "..",
> "$root_gen_dir/blink",
>
>
> It's not super pretty either, but it seems a lot better than having
> "newwtf".
>
> https://codereview.chromium.org/2703633003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yuta Kitamura, 2017-02-23 06:37:38]

On 2017/02/22 16:43:59, Nico wrote:
> Another idea would be to do this only on Windows (since it's already
> happening there and this would make it explicit). Not sure what's better,
> probably doesn't matter too much.
> 
> On Feb 22, 2017 11:07 AM, <mailto:thakis@chromium.org> wrote:
> 
> > Just syncing my windows box took like 25 minutes :-( Anyhow, this makes
> > things
> > go:
> >
> > C:\src\chrome\src>git diff
> > diff --git a/third_party/WebKit/Source/BUILD.gn
> > b/third_party/WebKit/Source/BUILD.gn
> > index ca5d37c..423e32a 100644
> > --- a/third_party/WebKit/Source/BUILD.gn
> > +++ b/third_party/WebKit/Source/BUILD.gn
> > @@ -77,6 +77,24 @@ config("blink_pch") {
> >
> > config("config") {
> > include_dirs = [
> > + # We're in the process of moving wtf from Source/wtf to
> > Source/platform/wtf.
> > + # To make the transition easier, we have some forwarding headers in
> > + # Source/wtf, for example Source/wtf/WTFExport.h includes
> > + # Source/platform/WTFExport.h.
> > + # MSVC adds the directories of all currently included files to the
> > + # include search path
> > + # (https://msdn.microsoft.com/en-us/library/36k2cdd4.aspx), so if any
> > file
> > + # includes any file from platform/, "wtf/WTFExport.h" will refer to
> > + # "platform/wtf/WTFExport.h" implicitly with MSVC but to
> > "wtf/WTFExport.h"
> > + # with the other compilers. To get consistent behavior across compilers,
> > + # explicitly add "platform" to the include search path _before_ '.'. This
> > + # way, "wtf/foo.h" will refer to "platform/wtf/foo.h" everywhere. Once
> > + # all #include lines are rewritten to refer to "platform/wtf/foo.h"
> > + # explicitly, this should be removed again.
> > + # TODO(yutak): Remove this once all includes have been rewritten,
> > + # https://crbug.com/XXX
> > + "platform",
> > +
> > ".",
> > "..",
> > "$root_gen_dir/blink",
> >
> >
> > It's not super pretty either, but it seems a lot better than having
> > "newwtf".
> >
> > https://codereview.chromium.org/2703633003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Thanks a lot! I'll try to experiment myself.

[Yuta Kitamura, 2017-02-23 07:43:08]

On 2017/02/23 06:37:38, Yuta Kitamura wrote:
> Thanks a lot! I'll try to experiment myself.

Nico's suggestion seems to work, so I'm going to revert
"newwtf" change earlier and try this again.

[Yuta Kitamura, 2017-02-24 07:17:04]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 07:17:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-02-24 07:31:13]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 07:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-02-24 07:33:26]

haraken, thakis: PTAL?

Nico, I need your approval for Source/BUILD.gn. Thanks!

[commit-bot: I haz the power, 2017-02-24 08:02:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 08:02:05]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[haraken, 2017-02-24 08:42:43]

On 2017/02/24 07:33:26, Yuta Kitamura wrote:
> haraken, thakis: PTAL?
> 
> Nico, I need your approval for Source/BUILD.gn. Thanks!

LGTM but Nico should definitely be a better reviewer for this.

[Yuta Kitamura, 2017-02-24 10:19:28]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 10:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 12:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 12:52:07]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2017-02-24 15:17:51]

build.gn lgtm

https://codereview.chromium.org/2703633003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/BUILD.gn (right):

https://codereview.chromium.org/2703633003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/BUILD.gn:83: # because these files are equivalent if
both exist.
i kind of liked my comment better, but oh well :-)

[Yuta Kitamura, 2017-02-27 06:48:48]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-02-27 06:49:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 06:55:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 06:55:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yuta Kitamura, 2017-02-27 07:11:43]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-02-27 07:12:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 07:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 07:20:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yuta Kitamura, 2017-02-27 08:59:04]

On 2017/02/27 07:20:01, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     third_party/WebKit/Source/BUILD.gn
> 
> Missing LGTM from an OWNER for these files:
>     third_party/WebKit/Source/BUILD.gn

Hmm, this is strange. I think Nico should cover this file...?
(And also I'm scolded twice for some reason)

[Nico, 2017-02-28 00:55:00]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-02-28 00:55:19]

Hm, strange, let's just try again...

[commit-bot: I haz the power, 2017-02-28 00:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:03:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:03:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-02-28 20:01:19]

Hm, I'd file an infra bug. Actually, let me do that :-) Filed
https://bugs.chromium.org/p/chromium/issues/detail?id=697156

On Mon, Feb 27, 2017 at 8:03 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Try jobs failed on following builders:
> chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/374106)
>
> https://codereview.chromium.org/2703633003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2017-02-28 20:01:24]

Hm, I'd file an infra bug. Actually, let me do that :-) Filed
https://bugs.chromium.org/p/chromium/issues/detail?id=697156

On Mon, Feb 27, 2017 at 8:03 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Try jobs failed on following builders:
> chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/374106)
>
> https://codereview.chromium.org/2703633003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2017-02-28 20:11:41]

On 2017/02/28 20:01:24, Nico wrote:
> Hm, I'd file an infra bug. Actually, let me do that :-) Filed
> https://bugs.chromium.org/p/chromium/issues/detail?id=697156

Strange. I'll look into it.

[Dirk Pranke, 2017-02-28 20:26:19]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-02-28 20:26:20]

lgtm in the meantime. Let's see if my approval works.

[Dirk Pranke, 2017-02-28 20:26:52]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2017-02-28 20:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 20:37:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 20:37:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2017-02-28 20:53:48]

On 2017/02/28 20:37:51, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Yeah, ok, I didn't think that'd work. I'll just TBR=dglazkov to get around this
for now.

[Dirk Pranke, 2017-02-28 20:54:12]

Description was changed from

==========
Add initial BUILD.gn in platform/wtf/, and move first a few files there.

This is the first attempt to move files in wtf/ to platform/wtf/. In this
commit, initial BUILD.gn is introduced in platform/wtf/, and the following
files are moved to platform/wtf/ as a proof that the new BUILD.gn actually
works.

The following files are moved at this time:
    WTFExport.h
    CryptographicallyRandomNumber.{h,cpp}

They are chosen because they have very minimum dependency on other files
in wtf/, and we need at least one cpp file to make the target linkable.

BUG=691465
==========

to

==========
Add initial BUILD.gn in platform/wtf/, and move first a few files there.

This is the first attempt to move files in wtf/ to platform/wtf/. In this
commit, initial BUILD.gn is introduced in platform/wtf/, and the following
files are moved to platform/wtf/ as a proof that the new BUILD.gn actually
works.

The following files are moved at this time:
    WTFExport.h
    CryptographicallyRandomNumber.{h,cpp}

They are chosen because they have very minimum dependency on other files
in wtf/, and we need at least one cpp file to make the target linkable.

BUG=691465
TBR=dglazkov@chromium.org
==========

[Dirk Pranke, 2017-02-28 20:54:13]

dpranke@chromium.org changed reviewers:
+ dglazkov@chromium.org

[Yuta Kitamura, 2017-03-07 06:03:22]

Description was changed from

==========
Add initial BUILD.gn in platform/wtf/, and move first a few files there.

This is the first attempt to move files in wtf/ to platform/wtf/. In this
commit, initial BUILD.gn is introduced in platform/wtf/, and the following
files are moved to platform/wtf/ as a proof that the new BUILD.gn actually
works.

The following files are moved at this time:
    WTFExport.h
    CryptographicallyRandomNumber.{h,cpp}

They are chosen because they have very minimum dependency on other files
in wtf/, and we need at least one cpp file to make the target linkable.

BUG=691465
TBR=dglazkov@chromium.org
==========

to

==========
Add initial BUILD.gn in platform/wtf/, and move first a few files there.

This is the first attempt to move files in wtf/ to platform/wtf/. In this
commit, initial BUILD.gn is introduced in platform/wtf/, and the following
files are moved to platform/wtf/ as a proof that the new BUILD.gn actually
works.

The following files are moved at this time:
    WTFExport.h
    CryptographicallyRandomNumber.{h,cpp}

They are chosen because they have very minimum dependency on other files
in wtf/, and we need at least one cpp file to make the target linkable.

BUG=691465
==========

[Yuta Kitamura, 2017-03-07 06:03:59]

I think the bug is fixed now? Remove TBR and try landing...

[Yuta Kitamura, 2017-03-07 06:04:10]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-03-07 06:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:57:42]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yuta Kitamura, 2017-03-07 09:18:36]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-03-07 09:19:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 11:42:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 11:42:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yuta Kitamura, 2017-03-08 05:33:13]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-03-08 05:33:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 09:06:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488951193302410,
"parent_rev": "ae16e9d846ee4a1d5a8d8968dcb4eefcd410fd0a", "commit_rev":
"00b8333a75c81b89aec8a377a33fa071a59e1748"}

[commit-bot: I haz the power, 2017-03-08 09:06:51]

Description was changed from

==========
Add initial BUILD.gn in platform/wtf/, and move first a few files there.

This is the first attempt to move files in wtf/ to platform/wtf/. In this
commit, initial BUILD.gn is introduced in platform/wtf/, and the following
files are moved to platform/wtf/ as a proof that the new BUILD.gn actually
works.

The following files are moved at this time:
    WTFExport.h
    CryptographicallyRandomNumber.{h,cpp}

They are chosen because they have very minimum dependency on other files
in wtf/, and we need at least one cpp file to make the target linkable.

BUG=691465
==========

to

==========
Add initial BUILD.gn in platform/wtf/, and move first a few files there.

This is the first attempt to move files in wtf/ to platform/wtf/. In this
commit, initial BUILD.gn is introduced in platform/wtf/, and the following
files are moved to platform/wtf/ as a proof that the new BUILD.gn actually
works.

The following files are moved at this time:
    WTFExport.h
    CryptographicallyRandomNumber.{h,cpp}

They are chosen because they have very minimum dependency on other files
in wtf/, and we need at least one cpp file to make the target linkable.

BUG=691465

Review-Url: https://codereview.chromium.org/2703633003
Cr-Commit-Position: refs/heads/master@{#455410}
Committed:
https://chromium.googlesource.com/chromium/src/+/00b8333a75c81b89aec8a377a33f...
==========

[commit-bot: I haz the power, 2017-03-08 09:06:53]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/00b8333a75c81b89aec8a377a33f...