Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2703613005: [autofill] Add rogerm@ to OWNERS for autofill components, browser and renderer (Closed)

Created:
3 years, 10 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[autofill] Add rogerm@ to OWNERS for autofill components, browser and renderer Also add sebsg to autofill renderer OWNERS Review-Url: https://codereview.chromium.org/2703613005 Cr-Commit-Position: refs/heads/master@{#451389} Committed: https://chromium.googlesource.com/chromium/src/+/2e044871bfa429df521ccbb61f80f244b103dc3f

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/autofill/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/autofill/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Roger McFarlane (Chromium)
PTAL?
3 years, 10 months ago (2017-02-17 20:27:43 UTC) #2
Mathieu
lgtm https://codereview.chromium.org/2703613005/diff/1/components/autofill/OWNERS File components/autofill/OWNERS (right): https://codereview.chromium.org/2703613005/diff/1/components/autofill/OWNERS#newcode4 components/autofill/OWNERS:4: rogerm@chromium.org alphabetical please
3 years, 10 months ago (2017-02-17 20:28:22 UTC) #3
Roger McFarlane (Chromium)
Thanks. https://codereview.chromium.org/2703613005/diff/1/components/autofill/OWNERS File components/autofill/OWNERS (right): https://codereview.chromium.org/2703613005/diff/1/components/autofill/OWNERS#newcode4 components/autofill/OWNERS:4: rogerm@chromium.org On 2017/02/17 20:28:22, Mathieu Perreault wrote: > ...
3 years, 10 months ago (2017-02-17 20:30:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703613005/20001
3 years, 10 months ago (2017-02-17 20:30:59 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 22:40:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2e044871bfa429df521ccbb61f80...

Powered by Google App Engine
This is Rietveld 408576698