Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2703613002: [Local NTP] Add a simple test for embeddedSearch.newTabPage.mostVisited (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
sfiera
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Local NTP] Add a simple test for embeddedSearch.newTabPage.mostVisited BUG=692002 Review-Url: https://codereview.chromium.org/2703613002 Cr-Commit-Position: refs/heads/master@{#451059} Committed: https://chromium.googlesource.com/chromium/src/+/f955fb9cd61c9b6b246a9484a60068eb38c54aec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/test/data/local_ntp_browsertest.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Marc Treib
PTAL!
3 years, 10 months ago (2017-02-16 17:37:40 UTC) #3
sfiera
LGTM
3 years, 10 months ago (2017-02-16 18:08:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703613002/1
3 years, 10 months ago (2017-02-16 18:35:26 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:45:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f955fb9cd61c9b6b246a9484a600...

Powered by Google App Engine
This is Rietveld 408576698