[Devtools] Changed protocol to use setBlockedURLs instead of add/remove

[Devtools] Changed protocol to use setBlockedURLs instead of add/remove

This patch just simplifies the protocol for network blocking in devtools
to instead use setBlockedURLs instead of {add/remove}BlockedURL.

R=pfeldman
BUG=693219

[allada, 2017-02-16 21:41:04]

Patchset #1 (id:1) has been deleted

[allada, 2017-02-16 21:42:18]

PTL

[allada, 2017-02-16 21:44:40]

Description was changed from

==========
[Devtools] Changed protocol to use setBlockedURLs instead of add/remove

This patch just simplifies the protocol for network blocking in devtools
to instead use setBlockedURLs instead of {add/remove}BlockedURL.

R=pfeldman
BUG=691164
==========

to

==========
[Devtools] Changed protocol to use setBlockedURLs instead of add/remove

This patch just simplifies the protocol for network blocking in devtools
to instead use setBlockedURLs instead of {add/remove}BlockedURL.

R=pfeldman
BUG=693219
==========

[allada, 2017-02-16 21:54:48]

Patchset #1 (id:20001) has been deleted

[allada, 2017-02-16 21:55:37]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 21:56:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-02-16 22:14:36]

Patchset #1 (id:40001) has been deleted

[allada, 2017-02-16 22:14:49]

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:695: /**
@type {!Set<string>} */
This was moved because this._agents is needed in _updateBlockedURLs.

[allada, 2017-02-16 22:14:57]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 22:16:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-02-16 22:29:25]

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:850:
this._updateBackendBlockedURLs();
inline backend update into this method.

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:857:
this._blockedURLs.add(url);
var blockedURLs = this._blockedSetting.get();
blockedURLs.push(url);
this._blockedSetting.set(blockedURLs);

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:866:
this._updateBackendBlockedURLs();
var blockedURLs = this._blockedSetting.get();
blockedURLs.delete(url);
this._blockedSetting.set(blockedURLs);

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:876:
this._updateBackendBlockedURLs();
_updateBlockedURLs()

[commit-bot: I haz the power, 2017-02-16 23:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 23:37:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[allada, 2017-02-17 00:58:06]

PTaL

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:850:
this._updateBackendBlockedURLs();
On 2017/02/16 22:29:24, pfeldman wrote:
> inline backend update into this method.

Done.

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:857:
this._blockedURLs.add(url);
On 2017/02/16 22:29:24, pfeldman wrote:
> var blockedURLs = this._blockedSetting.get();
> blockedURLs.push(url);
> this._blockedSetting.set(blockedURLs);

Done.

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:866:
this._updateBackendBlockedURLs();
On 2017/02/16 22:29:24, pfeldman wrote:
> var blockedURLs = this._blockedSetting.get();
> blockedURLs.delete(url);
> this._blockedSetting.set(blockedURLs);

Done.

https://codereview.chromium.org/2703603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:876:
this._updateBackendBlockedURLs();
On 2017/02/16 22:29:24, pfeldman wrote:
> _updateBlockedURLs()

Done.

[pfeldman, 2017-02-21 23:59:01]

https://codereview.chromium.org/2703603003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2703603003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:696:
this._blockedURLs = new Set();
Why duping the data, just keep the setting array.

https://codereview.chromium.org/2703603003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:840:
this._blockedURLs = new Set(this._blockedSetting.get());
this would become a local variable.

[allada, 2017-03-03 23:08:18]

Patchset #4 (id:120001) has been deleted

[allada, 2017-03-03 23:08:38]

PTaL

[pfeldman, 2017-03-06 18:23:10]

https://codereview.chromium.org/2703603003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2703603003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:697:
this._blockedSetting.set([]);
Don't add it here?

https://codereview.chromium.org/2703603003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:842:
agent.setBlockedURLs(urls);
It'be nice to not issue these calls unless necessary. Otherwise you are adding a
command issue at panel reveal.

https://codereview.chromium.org/2703603003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:852:
this._updateBlockedURLs();
It can be easily achieved via clearing the blocked urls here upon enable ==
false.