[Devtools] Persist network request blocking

[Devtools] Persist network request blocking settings

This patch persists network request blocking so when devtools is closed
and reopened it will keep the entries user requested to block.

R=pfeldman,luoe
BUG=691133

[allada, 2017-02-10 23:27:45]

PTL

[pfeldman, 2017-02-11 01:30:40]

You need to introduce "Enable blocking" toggle before you do this.

[allada, 2017-02-11 02:23:39]

PTaL w/ upstream dependency

[allada, 2017-02-11 02:44:47]

Patchset #3 (id:40001) has been deleted

[allada, 2017-02-11 02:44:53]

Patchset #2 (id:20001) has been deleted

[pfeldman, 2017-02-11 02:45:05]

what's the dependency?

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js
(right):

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js:913:
'networkBlockedURLs',
You should not change this, it is for the old front-ends.

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:758: var
blockedURLsSetting = Common.moduleSetting('networkBlockedURLs');
Move into Network module, also map it to the new enabled state, not to the
setting.

[allada, 2017-02-11 03:23:09]

Patchset #3 (id:80001) has been deleted

[allada, 2017-02-11 04:54:24]

Patchset #3 (id:100001) has been deleted

[allada, 2017-02-11 05:02:04]

PTaL

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js
(right):

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js:913:
'networkBlockedURLs',
On 2017/02/11 02:45:05, pfeldman wrote:
> You should not change this, it is for the old front-ends.

Done.

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2691433006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:758: var
blockedURLsSetting = Common.moduleSetting('networkBlockedURLs');
On 2017/02/11 02:45:05, pfeldman wrote:
> Move into Network module, also map it to the new enabled state, not to the
> setting.

Done.

[allada, 2017-02-11 05:05:40]

Patchset #3 (id:120001) has been deleted

[pfeldman, 2017-02-13 18:18:37]

I can't review this before other changes land!

[allada, 2017-03-03 23:27:57]

PTL

[pfeldman, 2017-03-06 18:16:57]

Does it really do what it says? "This patch persists network request blocking so
when devtools is closed
and reopened it will keep the settings."

[allada, 2017-03-06 18:23:17]

Description was changed from

==========
[Devtools] Persist network request blocking

This patch persists network request blocking so when devtools is closed
and reopened it will keep the settings.

R=pfeldman,luoe
BUG=691133
==========

to

==========
[Devtools] Persist network request blocking settings

This patch persists network request blocking so when devtools is closed
and reopened it will keep the entries user requested to block.

R=pfeldman,luoe
BUG=691133
==========

[allada, 2017-03-06 18:26:55]

On 2017/03/06 18:16:57, pfeldman wrote:
> Does it really do what it says? "This patch persists network request blocking
so
> when devtools is closed
> and reopened it will keep the settings."

Yes. (I updated the description slightly though)

[luoe, 2017-03-06 18:27:25]

allada@, after a recent change I landed, you'll need to rebase.  When you do,
please remove the 
"storageType": "session"
from sdk/module.json
(https://codereview.chromium.org/2708413003/diff/140001/third_party/WebKit/Sou...)

Session storage does not save across sessions, so to persist the setting, you'll
want to take it out.

[pfeldman, 2017-03-06 18:39:57]

Aren't you touching exact same line in another patch that actually does
something? :)