Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 27036: Get shared link working again. (Closed)

Created:
11 years, 10 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Get shared link working again. 1) The spell checker works, but it was still in temp_scaffolding_stubs. This meant different files had a different view of the class, causing memory corruption on startup. (Valgrind caught this. We need a Valgrind builder!) 2) The net library provides gtest-related bits and must depend on gtest.

Patch Set 1 #

Patch Set 2 : works on everyone but mac #

Patch Set 3 : new approach #

Patch Set 4 : with dom fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/common/temp_scaffolding_stubs.h View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/perf/perftests.scons View 1 chunk +4 lines, -0 lines 0 comments Download
M net/net_lib.scons View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Martin
This is the change I did earlier to make the shared build work. It also ...
11 years, 10 months ago (2009-02-23 21:44:45 UTC) #1
Lei Zhang
Doesn't apply cleanly to r10215, mostly LG though.
11 years, 10 months ago (2009-02-23 22:11:39 UTC) #2
Michael Moss
FYI, the other shared build changes are in.
11 years, 10 months ago (2009-02-24 00:15:08 UTC) #3
Scott Hess - ex-Googler
Hunspell wasn't present at all on Mac, I have changes which seem to let it ...
11 years, 10 months ago (2009-02-24 00:17:23 UTC) #4
Evan Martin
Hi all, I've uploaded a new patch that works around the mac problem.
11 years, 10 months ago (2009-02-24 19:22:32 UTC) #5
James Hawkins
11 years, 10 months ago (2009-02-24 19:54:16 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698