Add the hunspell project to Chrome.app and get spellchecker compiling for Mac.

Add the hunspell project to Chrome.app and get spellchecker compiling
for Mac.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10399

[Scott Hess - ex-Googler, 2009-02-24 23:46:10]

http://codereview.chromium.org/28053/diff/1006/28
File chrome/chrome.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/28053/diff/1006/28#newcode396
Line 396: CAA0C06A0F54B98F004DEE42 /* libhunspell.a in Frameworks */ = {isa =
PBXBuildFile; fileRef = CAA0BF9C0F54B3F5004DEE42 /* libhunspell.a */; };
When I use emacs to remove this duplicate, it doesn't work.

http://codereview.chromium.org/28053/diff/1006/28#newcode1765
Line 1765: remoteInfo = webkit;
XCode seems to insist on stuffing the webkit stanza in.  Couple other places,
too.

http://codereview.chromium.org/28053/diff/1006/28#newcode6663
Line 6663: FEATURE_DEFINES = "ENABLE_DATABASE=1 ENABLE_DASHBOARD_SUPPORT=0
ENABLE_JAVASCRIPT_DEBUGGER=0 ENABLE_JSC_MULTIPLE_THREADS=0 ENABLE_ICONDATABASE=0
ENABLE_XSLT=1 ENABLE_XPATH=1 ENABLE_SVG=1 ENABLE_SVG_ANIMATION=1
ENABLE_SVG_AS_IMAGE=1 ENABLE_SVG_USE=1 ENABLE_SVG_FOREIGN_OBJECT=1
ENABLE_SVG_FONTS=1 ENABLE_VIDEO=0
WEBCORE_NAVIGATOR_PLATFORM_=\"FixMeAndRemoveTrailingUnderscore\"
USE_GOOGLE_URL_LIBRARY USE_SYSTEM_MALLOC=1 XP_MACOSX=1\nENABLE_DATABASE=1
ENABLE_DASHBOARD_SUPPORT=0 ENABLE_JAVASCRIPT_DEBUGGER=0
ENABLE_JSC_MULTIPLE_THREADS=0 ENABLE_ICONDATABASE=0 ENABLE_XSLT=1 ENABLE_XPATH=1
ENABLE_SVG=1 ENABLE_SVG_ANIMATION=1 ENABLE_SVG_AS_IMAGE=1 ENABLE_SVG_USE=1
ENABLE_SVG_FOREIGN_OBJECT=1 ENABLE_SVG_FONTS=1 ENABLE_VIDEO=0
WEBCORE_NAVIGATOR_PLATFORM_=\"FixMeAndRemoveTrailingUnderscore\"
USE_GOOGLE_URL_LIBRARY USE_SYSTEM_MALLOC=1 XP_MACOSX=1
HUNSPELL_CHROME_CLIENT=1";
Don't know if anyone notices, but many of those defines are in there twice. 
Should I remove, or do I need HUNSPELL_CHROME_CLIENT in there twice?

[Mark Mentovai, 2009-02-25 05:14:35]

LG™.  Well-sorted too, nice, I approve.

http://codereview.chromium.org/28053/diff/1006/28
File chrome/chrome.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/28053/diff/1006/28#newcode396
Line 396: CAA0C06A0F54B98F004DEE42 /* libhunspell.a in Frameworks */ = {isa =
PBXBuildFile; fileRef = CAA0BF9C0F54B3F5004DEE42 /* libhunspell.a */; };
shess wrote:
> When I use emacs to remove this duplicate, it doesn't work.

These aren't duplicates.  You get a different PBXBuildFile for each target that
references libhunspell.a.  This is expected and correct.

http://codereview.chromium.org/28053/diff/1006/28#newcode1765
Line 1765: remoteInfo = webkit;
shess wrote:
> XCode seems to insist on stuffing the webkit stanza in.  Couple other places,
> too.

This is also expected.  Darin recently added a new target to webkit.xcodeproj,
named webkit.  Now any xcodeproj that points to webkit.xcodeproj will see these
extra PBXContainerItemProxy and PBXReferenceProxy objects added to reference the
new products that webkit.xcodeproj can provide.

http://codereview.chromium.org/28053/diff/1006/28#newcode2675
Line 2675: CAA0BC4B0F54A8F7004DEE42 /* hunspell.xcodeproj */ = {isa =
PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name =
hunspell.xcodeproj; path = chrome/third_party/hunspell/hunspell.xcodeproj;
sourceTree = "<group>"; };
Only one PBXFileReference - this is where you'd be worried about duplicates, but
there's no duplicate, so things are cool.