Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2703553002: Revert of Allow a ParseInfo without a script for %SetCode users (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Allow a ParseInfo without a script for %SetCode users (patchset #5 id:220001 of https://codereview.chromium.org/2684033007/ ) Reason for revert: Please remove the file in status file too. Breaks presubmit: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20presubmit/builds/14754 Or lets call it post-submit :( Original issue's description: > This is a workaround for the fact that %SetCode can "lose" the script for a js native. If the js native is re-initialized (for a Realm or something), then the source SharedFunctionInfo won't have a script anymore. Nonetheless, we may want to optimize the function. If we've compiled bytecode, then we can compile optimized code without a script. > > Here, we carve out a special exception for this case, so that we can turn on the --mark-shared-functions-for-tier-up. > > BUG=v8:5946 > R=leszeks@chromium.org > > Review-Url: https://codereview.chromium.org/2684033007 > Cr-Commit-Position: refs/heads/master@{#43240} > Committed: https://chromium.googlesource.com/v8/v8/+/4123a3dd790495c40cf839990318a85c146e057d TBR=leszeks@chromium.org,mstarzinger@chromium.org,marja@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5946 Review-Url: https://codereview.chromium.org/2703553002 Cr-Commit-Position: refs/heads/master@{#43242} Committed: https://chromium.googlesource.com/v8/v8/+/4d942ac74198d2a4fc9e60464266b114dd562ef8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -101 lines) Patch
M src/compiler.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M src/compiler/pipeline.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +8 lines, -16 lines 0 comments Download
M src/parsing/parse-info.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M src/source-position.cc View 3 chunks +13 lines, -24 lines 0 comments Download
A test/mjsunit/shared-function-tier-up-ignition.js View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Allow a ParseInfo without a script for %SetCode users
3 years, 10 months ago (2017-02-16 10:39:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703553002/1
3 years, 10 months ago (2017-02-16 10:39:43 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 10:40:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4d942ac74198d2a4fc9e60464266b114dd5...

Powered by Google App Engine
This is Rietveld 408576698