Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2703543002:
Add //third_party/apache-win32 as LayoutTest dep. (Closed)
DescriptionAdd //third_party/apache-win32 as LayoutTest dep.
Apache is needed for Webkit LayoutTests and doesn't come with Windows.
Needs to be used from //third_party/apache-win32
BUG=692995
Review-Url: https://codereview.chromium.org/2703543002
Cr-Commit-Position: refs/heads/master@{#450951}
Committed: https://chromium.googlesource.com/chromium/src/+/820f7df12cfab494d649d7e99d3a060d6b4e7c91
Patch Set 1 #Patch Set 2 : Add //third_party/apache-win32 as LayoutTest dep. #Patch Set 3 : Add //third_party/apache-win32 as LayoutTest dep. #Messages
Total messages: 22 (17 generated)
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tansell@chromium.org changed reviewers: + dpranke@google.com, jochen@chromium.org
Hi! Small fix for running LayoutTests on swarming on Windows. First LGTM wins. Tim 'mithro' Ansell
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487249603940940,
"parent_rev": "9ca24bfb8a66a0731bdedebb7705a05b8b631623", "commit_rev":
"820f7df12cfab494d649d7e99d3a060d6b4e7c91"}
Message was sent while issue was closed.
Description was changed from ========== Add //third_party/apache-win32 as LayoutTest dep. Apache is needed for Webkit LayoutTests and doesn't come with Windows. Needs to be used from //third_party/apache-win32 BUG=692995 ========== to ========== Add //third_party/apache-win32 as LayoutTest dep. Apache is needed for Webkit LayoutTests and doesn't come with Windows. Needs to be used from //third_party/apache-win32 BUG=692995 Review-Url: https://codereview.chromium.org/2703543002 Cr-Commit-Position: refs/heads/master@{#450951} Committed: https://chromium.googlesource.com/chromium/src/+/820f7df12cfab494d649d7e99d3a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/820f7df12cfab494d649d7e99d3a...
Message was sent while issue was closed.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Message was sent while issue was closed.
lgtm |
