Issue 270353003: Statically initialize those zero-size singletons.

Issue 270353003: Statically initialize those zero-size singletons. (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
bungeman-skia, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Statically initialize those zero-size singletons. This way GCC/Clang don't generate the magic static code to call the pointless T::T() once in a threadsafe way. = {} is plenty initialized. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14623 Committed: http://code.google.com/p/skia/source/detail?r=14626

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
M	gyp/common_conditions.gypi	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/record/SkRecord.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/record/SkRecords.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/270353003/1

6 years, 7 months ago (2014-05-07 19:08:20 UTC) #4

mtklein

A revert of this CL has been created in https://codereview.chromium.org/270363005/ by mtklein@google.com. The reason for ...

6 years, 7 months ago (2014-05-07 19:32:35 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/270353003/20001

6 years, 7 months ago (2014-05-07 19:50:42 UTC) #8

Message was sent while issue was closed.

Change committed as 14626