src/record/SkRecord.h - Issue 270353003: Statically initialize those zero-size singletons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/record/SkRecord.h

Issue 270353003: Statically initialize those zero-size singletons. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: disable warning Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/record/SkRecord.h

diff --git a/src/record/SkRecord.h b/src/record/SkRecord.h

index ccfa1dd556441011df4c17f2ff827f560d064f4d..068155e47fa439d0905f01bb10317adc95a98b02 100644

--- a/src/record/SkRecord.h

+++ b/src/record/SkRecord.h

@@ -167,7 +167,7 @@ private:

// We could just return NULL but it's sort of confusing to return NULL on success.

template <typename T>

SK_WHEN(SkTIsEmpty<T>, T*) allocCommand() {

- static T singleton;

+ static T singleton = {};

return &singleton;

}

« no previous file with comments | « gyp/common_conditions.gypi ('k') | src/record/SkRecords.h » ('j') | no next file with comments »