WIP: move OffscreenCanvas into new display compositor

Move OffscreenCanvas into new display compositor

Things need to check:
1), BeginFrame implementation.


BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

[xing.xu, 2017-02-16 08:55:55]

Description was changed from

==========
[Test] OffscreenCanvas

BUG=
==========

to

==========
[Test] OffscreenCanvas

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-02-16 08:58:08]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 08:58:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 09:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 09:03:41]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xing.xu, 2017-02-16 14:30:48]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 14:31:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 14:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 14:35:32]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xing.xu, 2017-02-16 14:48:25]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 14:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-02-16 14:51:16]

Description was changed from

==========
[Test] OffscreenCanvas

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move OffscreenCanvas into new display compositor

BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-02-16 15:04:50]

Description was changed from

==========
Move OffscreenCanvas into new display compositor

BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move OffscreenCanvas into new display compositor

Things need to check:
1), OnPrivateConnectionLost OnClientConnectionLost when destroy(close winow)
2), in RenderProcessHostImpl::CreateOffscreenCanvasCompositorFrameSinkProvider:
 // display_compositor_->Add(std::move(request));
3), 
+DisplayCompositor::DisplayCompositor(
+    cc::mojom::DisplayCompositorRequest request)
+    : manager_(cc::SurfaceManager::LifetimeType::REFERENCES),
+      binding_(this, std::move(request)) {
+  // Replaced manager_ with surface_utils.
+}


BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-02-17 00:11:12]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 00:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-02-17 00:58:02]

The CQ bit was unchecked by xing.xu@intel.com

[xing.xu, 2017-02-17 01:18:06]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 01:20:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-02-17 02:00:51]

The CQ bit was unchecked by xing.xu@intel.com

[xing.xu, 2017-02-17 03:10:38]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 03:12:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:26:13]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[xing.xu, 2017-02-20 02:41:26]

Description was changed from

==========
Move OffscreenCanvas into new display compositor

Things need to check:
1), OnPrivateConnectionLost OnClientConnectionLost when destroy(close winow)
2), in RenderProcessHostImpl::CreateOffscreenCanvasCompositorFrameSinkProvider:
 // display_compositor_->Add(std::move(request));
3), 
+DisplayCompositor::DisplayCompositor(
+    cc::mojom::DisplayCompositorRequest request)
+    : manager_(cc::SurfaceManager::LifetimeType::REFERENCES),
+      binding_(this, std::move(request)) {
+  // Replaced manager_ with surface_utils.
+}


BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move OffscreenCanvas into new display compositor

Things need to check:
1), BeginFrame implementation.


BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-02-20 02:41:26]

Description was changed from

==========
Move OffscreenCanvas into new display compositor

Things need to check:
1), OnPrivateConnectionLost OnClientConnectionLost when destroy(close winow)
2), in RenderProcessHostImpl::CreateOffscreenCanvasCompositorFrameSinkProvider:
 // display_compositor_->Add(std::move(request));
3), 
+DisplayCompositor::DisplayCompositor(
+    cc::mojom::DisplayCompositorRequest request)
+    : manager_(cc::SurfaceManager::LifetimeType::REFERENCES),
+      binding_(this, std::move(request)) {
+  // Replaced manager_ with surface_utils.
+}


BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move OffscreenCanvas into new display compositor

Things need to check:
1), BeginFrame implementation.


BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-02-21 14:16:17]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-02-21 14:16:18]

https://codereview.chromium.org/2703503002/diff/150001/cc/ipc/display_composi...
File cc/ipc/display_compositor.mojom (right):

https://codereview.chromium.org/2703503002/diff/150001/cc/ipc/display_composi...
cc/ipc/display_compositor.mojom:62: CreateOffscreenCanvasCompositorFrameSink(
I don't think we should special case offscreen canvas. It should be no different
from any other client.

https://codereview.chromium.org/2703503002/diff/150001/content/browser/render...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/2703503002/diff/150001/content/browser/render...
content/browser/renderer_host/render_process_host_impl.cc:1382:
display_compositor_.reset(
This isn't the right place to use DisplayCompositor. There should only be one of
these objects in the system. Please see my patch. You want a DisplayCompositor
in GpuProcessTransportFactory, most likely.

[xing.xu, 2017-02-21 14:42:44]

On 2017/02/21 14:16:18, Fady Samuel wrote:
>
https://codereview.chromium.org/2703503002/diff/150001/cc/ipc/display_composi...
> File cc/ipc/display_compositor.mojom (right):
> 
>
https://codereview.chromium.org/2703503002/diff/150001/cc/ipc/display_composi...
> cc/ipc/display_compositor.mojom:62: CreateOffscreenCanvasCompositorFrameSink(
> I don't think we should special case offscreen canvas. It should be no
different
> from any other client.
> 
>
https://codereview.chromium.org/2703503002/diff/150001/content/browser/render...
> File content/browser/renderer_host/render_process_host_impl.cc (right):
> 
>
https://codereview.chromium.org/2703503002/diff/150001/content/browser/render...
> content/browser/renderer_host/render_process_host_impl.cc:1382:
> display_compositor_.reset(
> This isn't the right place to use DisplayCompositor. There should only be one
of
> these objects in the system. Please see my patch. You want a DisplayCompositor
> in GpuProcessTransportFactory, most likely.

Thanks Fady!