Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2703443004: Add Web Components page sets and benchmark

Created:
3 years, 10 months ago by hayato
Modified:
3 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Web Components page sets and benchmark Add a benchmark for measuring loading metrics for applications which use Web Components. The page set contains only sample shopping application in Polymer 2. We have a plan to add more pages and stories. Now the benchmark is using loadingMetrics as is. That could be changed in the future. BUG=703996

Patch Set 1 #

Patch Set 2 : WIP: #

Patch Set 3 : WIP: #

Patch Set 4 : wip #

Patch Set 5 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1142 lines, -0 lines) Patch
M testing/buildbot/chromium.perf.json View 1 2 3 16 chunks +912 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 1 2 3 3 chunks +171 lines, -0 lines 0 comments Download
M tools/perf/benchmark.csv View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/benchmarks/web_components.py View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/web_components.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/web_components_000.wpr.sha1 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/web_components.py View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
hayato
WIP:
3 years, 9 months ago (2017-03-21 05:59:11 UTC) #5
hayato
WIP:
3 years, 9 months ago (2017-03-22 06:24:28 UTC) #6
hayato
wip
3 years, 8 months ago (2017-03-30 05:30:57 UTC) #7
hayato
wip
3 years, 8 months ago (2017-03-30 05:43:13 UTC) #10
hayato
PTAL
3 years, 8 months ago (2017-03-30 05:56:56 UTC) #15
nednguyen
On 2017/03/30 05:56:56, hayato wrote: > PTAL This looks right to me, though can I ...
3 years, 8 months ago (2017-03-30 07:06:15 UTC) #16
hayato
On 2017/03/30 at 07:06:15, nednguyen wrote: > On 2017/03/30 05:56:56, hayato wrote: > > PTAL ...
3 years, 8 months ago (2017-03-30 07:41:22 UTC) #19
hayato
nedguyen@, it looks that the idea of using experimental folder is getting approved in the ...
3 years, 8 months ago (2017-04-05 03:33:00 UTC) #20
nednguyen
On 2017/04/05 03:33:00, hayato wrote: > nedguyen@, it looks that the idea of using experimental ...
3 years, 8 months ago (2017-04-06 15:44:50 UTC) #21
hayato
Thanks. This is not an urgent request because I think I am the only user ...
3 years, 8 months ago (2017-04-07 04:03:20 UTC) #22
nednguyen
On 2017/04/07 04:03:20, hayato wrote: > Thanks. This is not an urgent request because I ...
3 years, 7 months ago (2017-05-17 13:47:30 UTC) #23
hayato
3 years, 7 months ago (2017-05-18 01:32:59 UTC) #24
On 2017/05/17 at 13:47:30, nednguyen wrote:
> On 2017/04/07 04:03:20, hayato wrote:
> > Thanks. This is not an urgent request because I think I am the only user of
this
> > benchmark, at least for a month, or a quarter.
> > You don't need to think this as a high priority task. :)
> 
> Sorry for the delay. tools/perf/contrib is landed. You can land you web
component tests there. 
> 
> Also loading.desktop benchmark is landed. You can also consider adding your
test cases to
https://cs.chromium.org/chromium/src/tools/perf/page_sets/loading_desktop.py?...
> 
> However, because we are trying to keep the cycle time of tests small, you may
want to sync with Kouhei & Ksakamoto on how to keep the test time budget
unchanged with your new stories (maybe punting some of the old stories)

No problem. Thank you for your work!
Let me check what has changed, and consult kouhei@ and ksakamoto@ if necessary,
as you recommended.

I am afraid that I won't resume this task soon because I am now working on other
task. Let me ping you again when the CL is ready to be reviewed.

Powered by Google App Engine
This is Rietveld 408576698