[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Adding COMPONENT/TEAM information into OWNERS file.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=wfh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2703443002
Cr-Commit-Position: refs/heads/master@{#468246}
Committed: https://chromium.googlesource.com/chromium/src/+/2806d41895a1af68b3c3f85511792a79a462b3ae

[ymzhang1, 2017-02-15 22:52:03]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[ymzhang1, 2017-02-15 22:52:04]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ymzhang1, 2017-02-15 22:55:13]

Patchset #1 (id:1) has been deleted

[ymzhang1, 2017-02-15 22:56:00]

ymzhang@chromium.org changed reviewers:
+ wfh@chromium.org

[ymzhang1, 2017-02-15 22:56:01]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[ymzhang1, 2017-02-24 22:30:49]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[ymzhang1, 2017-02-24 22:31:23]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Adding COMPONENT/TEAM information into OWNERS file.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=wfh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Will Harris, 2017-02-24 22:35:51]

vabr -> PTAL

https://codereview.chromium.org/2703443002/diff/20001/sandbox/win/OWNERS
File sandbox/win/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/sandbox/win/OWNERS#newc...
sandbox/win/OWNERS:7: # TEAM: security-dev@chromium.org
wait, didn't we put this in the parent directory?

https://codereview.chromium.org/2703443002/diff/20001/third_party/fips181/OWNERS
File third_party/fips181/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/third_party/fips181/OWN...
third_party/fips181/OWNERS:5: # COMPONENT: Internals>Core
this should probably be

TEAM: password manager people, not sure what their email is +vabr
COMPONENT: UI>Browser>Passwords>Generation

[Will Harris, 2017-02-24 22:39:06]

sorry, missed a few.

https://codereview.chromium.org/2703443002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/plugin_metadata/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/chrome/browser/resource...
chrome/browser/resources/plugin_metadata/OWNERS:5: # COMPONENT:
Internals>Network
COMPONENT: Internals>Plugins

https://codereview.chromium.org/2703443002/diff/20001/third_party/tcmalloc/OW...
File third_party/tcmalloc/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/third_party/tcmalloc/OW...
third_party/tcmalloc/OWNERS:4: # TEAM: layout-dev@chromium.org
layout-dev is described as "Mailing list for the Blink Layout Team." I don't
think the allocator should belong to them. But equally we don't have a core-dev
team.

I'd use whatever we use for base/allocator here.

[ymzhang1, 2017-02-24 22:51:21]

ymzhang@chromium.org changed reviewers:
+ vabr@chromium.org

[ymzhang1, 2017-02-24 22:51:22]

Thanks for the comments. Have updated. 

+vabr
Do we have a team mailing list for component UI>Browser>Passwords>Generation
(see detail in third_party/fips181/OWNERS)? Thanks.

https://codereview.chromium.org/2703443002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/plugin_metadata/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/chrome/browser/resource...
chrome/browser/resources/plugin_metadata/OWNERS:5: # COMPONENT:
Internals>Network
On 2017/02/24 22:39:05, Will Harris wrote:
> COMPONENT: Internals>Plugins 

Done.

https://codereview.chromium.org/2703443002/diff/20001/sandbox/win/OWNERS
File sandbox/win/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/sandbox/win/OWNERS#newc...
sandbox/win/OWNERS:7: # TEAM: security-dev@chromium.org
On 2017/02/24 22:35:50, Will Harris wrote:
> wait, didn't we put this in the parent directory?

We try to add component/team in every OWNERS file. 

Some sub-directories don't share the same component with their parent directory.
Thus I would like to verify every sub-directories OWNERS file as well.

I would remove this line component+team. Thanks!

https://codereview.chromium.org/2703443002/diff/20001/third_party/fips181/OWNERS
File third_party/fips181/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/third_party/fips181/OWN...
third_party/fips181/OWNERS:5: # COMPONENT: Internals>Core
On 2017/02/24 22:35:50, Will Harris wrote:
> this should probably be
> 
> TEAM: password manager people, not sure what their email is +vabr
> COMPONENT: UI>Browser>Passwords>Generation

Done.

https://codereview.chromium.org/2703443002/diff/20001/third_party/tcmalloc/OW...
File third_party/tcmalloc/OWNERS (right):

https://codereview.chromium.org/2703443002/diff/20001/third_party/tcmalloc/OW...
third_party/tcmalloc/OWNERS:4: # TEAM: layout-dev@chromium.org
On 2017/02/24 22:39:05, Will Harris wrote:
> layout-dev is described as "Mailing list for the Blink Layout Team." I don't
> think the allocator should belong to them. But equally we don't have a
core-dev
> team.
> 
> I'd use whatever we use for base/allocator here.

Thanks for pointing out! I'll remove this team information. Currently we have
component Internals and no team information in base/allocator.

[vabr (Chromium), 2017-02-25 14:21:41]

> Do we have a team mailing list for component UI>Browser>Passwords>Generation
> (see detail in third_party/fips181/OWNERS)? Thanks.

I'm afraid we have no @chromium.org mailing list for password manager (we have
an internal one with @google.com, but that's not useful here). The closest one
can use is chromium-dev@chromium.org.

Cheers,
Vaclav

[ymzhang1, 2017-02-27 17:49:56]

Yeah, we won't add internal mailing list here. I'll put
chromium-dev@chromium.org for component UI>Browser>Passwords>Generation. Thanks!

[vabr (Chromium), 2017-03-02 18:48:11]

I do not own any of this, but LGTM. :)
Cheers,
Vaclav

[ymzhang1, 2017-03-10 00:48:42]

@wfh:

Would you mind lgtm this cl if the added component/team is correct? Thanks!

-Yangmuzi

[Will Harris, 2017-04-27 18:21:34]

lgtm

[ymzhang1, 2017-04-29 14:56:31]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-04-29 14:56:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 16:06:09]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493477791499330,
"parent_rev": "c43891b29b93034092bb3f07df7e76474b681769", "commit_rev":
"2806d41895a1af68b3c3f85511792a79a462b3ae"}

[commit-bot: I haz the power, 2017-04-29 16:06:18]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Adding COMPONENT/TEAM information into OWNERS file.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=wfh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Adding COMPONENT/TEAM information into OWNERS file.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=wfh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2703443002
Cr-Commit-Position: refs/heads/master@{#468246}
Committed:
https://chromium.googlesource.com/chromium/src/+/2806d41895a1af68b3c3f8551179...
==========

[commit-bot: I haz the power, 2017-04-29 16:06:22]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2806d41895a1af68b3c3f8551179...