Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2703433002: DevTools: Do not do deep search in case of bottom-up profile tree. (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
Reviewers:
kozy, caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not do deep search in case of bottom-up profile tree. Perform the search among top level items only. Review-Url: https://codereview.chromium.org/2703433002 Cr-Commit-Position: refs/heads/master@{#451044} Committed: https://chromium.googlesource.com/chromium/src/+/920466c7ebd38d651e6e411603162167106f3e4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 chunk +4 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
alph
3 years, 10 months ago (2017-02-15 22:01:46 UTC) #2
dgozman
Alexey, could you please take a look?
3 years, 10 months ago (2017-02-15 22:26:48 UTC) #4
caseq
lgtm
3 years, 10 months ago (2017-02-15 22:39:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703433002/1
3 years, 10 months ago (2017-02-15 23:20:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/154416)
3 years, 10 months ago (2017-02-16 00:48:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703433002/1
3 years, 10 months ago (2017-02-16 00:52:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
3 years, 10 months ago (2017-02-16 01:22:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703433002/1
3 years, 10 months ago (2017-02-16 17:47:05 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:21:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/920466c7ebd38d651e6e41160316...

Powered by Google App Engine
This is Rietveld 408576698