Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2703423009: Add use counters for recently launched canvas features (Closed)

Created:
3 years, 10 months ago by Justin Novosad
Modified:
3 years, 9 months ago
Reviewers:
zmo, haraken, xlai (Olivia), jwd
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, asvitkine+watch_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counters for recently launched canvas features This change adds use counters for the following features: * 2D Canvas filter * 2D Canvas imageSmoothingQuality * <canvas> toBlob and toDataURL * OffscreenCanvas.convertToBlob * using SVG images as source images for ctx2d.drawImage and gl.texImage2d Use counter for imageSmoothingEnabled is removed. This feature was being tracked for the purpose deprecating and removing its webkit-prefixed version. We no longer need it The Canvas.ContextType histogram was missing an entry for the "bitmaprenderer" context type. BUG=653599 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2703423009 Cr-Commit-Position: refs/heads/master@{#453368} Committed: https://chromium.googlesource.com/chromium/src/+/19c0e98f042d6d357e07c101911a724f0086a394

Patch Set 1 #

Patch Set 2 : histo fix #

Messages

Total messages: 26 (14 generated)
Justin Novosad
PTAL
3 years, 10 months ago (2017-02-24 00:10:37 UTC) #5
jwd
LGTM histograms
3 years, 10 months ago (2017-02-24 15:58:48 UTC) #8
xlai (Olivia)
lgtm
3 years, 10 months ago (2017-02-24 17:11:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703423009/20001
3 years, 10 months ago (2017-02-24 17:11:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/372436)
3 years, 10 months ago (2017-02-24 17:20:53 UTC) #13
xlai (Olivia)
On 2017/02/24 17:20:53, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 10 months ago (2017-02-24 17:46:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703423009/20001
3 years, 10 months ago (2017-02-24 18:03:02 UTC) #16
Justin Novosad
+zmo for WebGL OWNERS
3 years, 10 months ago (2017-02-24 18:06:35 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/372476)
3 years, 10 months ago (2017-02-24 18:11:48 UTC) #20
haraken
owner LGTM
3 years, 10 months ago (2017-02-25 00:09:36 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703423009/20001
3 years, 9 months ago (2017-02-27 20:01:47 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:49:35 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19c0e98f042d6d357e07c101911a...

Powered by Google App Engine
This is Rietveld 408576698