Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2703413004: Rename CRIWV class to CWV. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CRIWV class to CWV. BUG=690807 Review-Url: https://codereview.chromium.org/2703413004 Cr-Commit-Position: refs/heads/master@{#452907} Committed: https://chromium.googlesource.com/chromium/src/+/f9cb6a502f37bb663d158bcb09a0a231f8519e64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -134 lines) Patch
M ios/web_view/internal/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D ios/web_view/internal/criwv.mm View 1 chunk +0 lines, -74 lines 0 comments Download
M ios/web_view/internal/criwv_browser_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/criwv_network_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/criwv_url_request_context_getter.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/criwv_web_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/criwv_web_main_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/criwv_web_main_parts.h View 1 chunk +1 line, -1 line 0 comments Download
A + ios/web_view/internal/cwv.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M ios/web_view/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D ios/web_view/public/criwv.h View 1 chunk +0 lines, -31 lines 0 comments Download
A + ios/web_view/public/cwv.h View 3 chunks +7 lines, -8 lines 0 comments Download
M ios/web_view/public/cwv_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/public/cwv_web_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/shell/shell_app_delegate.m View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/web_view/shell/shell_view_controller.m View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 2710683007 Patch 1

Messages

Total messages: 8 (4 generated)
michaeldo
3 years, 10 months ago (2017-02-22 21:05:26 UTC) #2
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-23 14:19:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703413004/1
3 years, 10 months ago (2017-02-24 18:16:59 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 19:51:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9cb6a502f37bb663d158bcb09a0...

Powered by Google App Engine
This is Rietveld 408576698